1209842 - FxOS private browsing visual tweaks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Kevin Grandon :kgrandon]

1). Add in learn more link in between ‘Don’t tell me again’ checkbox and the button.  
Same as text above but in #00caf2 and underlined
https://support.mozilla.org/en-US/kb/private-browsing-firefox-os

2. Reduce font size of ‘Don’t Tell me again’ to 13px

3. Move ok button down so it has a margin of 15px from the soft home button.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1209842_search_private_window_link > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8667734 [details] [review]
[gaia] KevinGrandon:bug_1209842_search_private_window_link > mozilla-b2g:master

Reza - would you mind reviewing this when you get a chance? Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Updated implementation - Flame screenshot

Hi Eric,

Here's a screenshot with the implementation. Please note this is on a Flame. I didn't have exact measurements for the flame screen, but tried to eyeball it. Please let me know if you'd like to have anything updated. Thanks!

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8667741 [details]
Updated implementation - Flame screenshot

Looks good to me, thanks for making the updates Kevin!

Comment 5

[Reza Akhavan [:jedireza]]

Comment on attachment 8667734 [details] [review]
[gaia] KevinGrandon:bug_1209842_search_private_window_link > mozilla-b2g:master

LGTM. Tested locally to confirm.

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/0954281e492f1996c3ecf5f4aff4cc8554bc0521

Comment 7

[Francesco Lodolo [:flod]]

Kevin, what is the reason for exposing the URL as a localizable string?

1) As a general rule, when linking to Mozilla properties (MDN, SUMO, mozilla.org, etc.) leave out the locale code. 

https://support.mozilla.org/kb/private-browsing-firefox-os 
Unlike the current one this will redirect you to the best language available for your accept_languages header

2) You'll need to touch strings whenever you decide to update this URL, which is far from optimal (or impossible during string freeze).

Comment 8

[Kevin Grandon :kgrandon]

Thanks for catching this as always Francesco. I'll submit a follow-up to fix this shortly.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1209842_follow_up_private_support_href > mozilla-b2g:master

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8668816 [details] [review]
[gaia] KevinGrandon:bug_1209842_follow_up_private_support_href > mozilla-b2g:master

Just a simple follow-up to change the way localization is handled. R=me.

Comment 11

[Kevin Grandon :kgrandon]

Follow-up in master: https://github.com/mozilla-b2g/gaia/commit/337787b06ca0ac2b27388ea34499753b328a8647

Comment 12

[Francesco Lodolo [:flod]]

Thanks Kevin for the quick fix, looks great now.