Update our in-tree ICU to 56

RESOLVED FIXED in Firefox 45

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Waldo, Assigned: jfkthame)

Tracking

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 affected, firefox45 fixed)

Details

Attachments

(4 attachments)

Somewhat for general staying-updated hygiene, but the release notes do mention this bit of especial interestingness:

"ICU data size reduced by about 7.2% (1.8MB) via sharing string values across resource bundles"

http://site.icu-project.org/download/56

ICU 56 is scheduled for release on October 7.
http://site.icu-project.org/

"2015-10-07: ICU 56.1 is now available. For details about new features and other improvements, see ICU 56 download page."
I think that we have to apply http://bugs.icu-project.org/trac/ticket/11959 when upgrading to 56.1
Blocks: 1215247
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8688413 - Flags: review?(jwalden+bmo)
Running the update-icu script results in a 17MB patch. I haven't attached that here, as it's too big, and is entirely auto-generated. Consider it to come before the patch to update normalization test data.
The above patches seem to work for me locally; I'll push a try job to see how that goes...
Turns out the update caused a test failure in DateTimeFormat, but this is due to an expected change in the locale data for Morocco; see http://unicode.org/cldr/trac/changeset/11850. So we need to update our test accordingly.
Attachment #8688447 - Flags: review?(jwalden+bmo)
Comment on attachment 8688408 [details] [diff] [review]
Tweak the update-icu script ready for release 56

Review of attachment 8688408 [details] [diff] [review]:
-----------------------------------------------------------------

This was surprisingly small.  Woo for a carefully-curated update script!
Attachment #8688408 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 8688412 [details] [diff] [review]
Update normalization test data for ICU 56 (Unicode 8.0) release

Review of attachment 8688412 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8688412 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 8688413 [details] [diff] [review]
ICU update requires a CLOBBER

Review of attachment 8688413 [details] [diff] [review]:
-----------------------------------------------------------------

Is this merely precautionary, or are you sure it'll happen?  I can't remember if there's a bug on file to make this not necessary, should it actually still be necessary.  If it is, we should file one (and cite that bug as well in CLOBBER).
Attachment #8688413 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 8688447 [details] [diff] [review]
Update test Intl/DateTimeFormat/format.js to expect 24-hour time in Arabic/Morocco locale

Review of attachment 8688447 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8688447 - Flags: review?(jwalden+bmo) → review+
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #13)
> Comment on attachment 8688413 [details] [diff] [review]
> ICU update requires a CLOBBER
> 
> Review of attachment 8688413 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is this merely precautionary, or are you sure it'll happen? 

It failed to build for me locally until I clobbered.

> I can't
> remember if there's a bug on file to make this not necessary, should it
> actually still be necessary.  If it is, we should file one (and cite that
> bug as well in CLOBBER).

That'll be bug 966038.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dae44b477b62fae4b4a23a8f6e8bcfeb58bdc597
Bug 1210165 - Tweak the update-icu script ready for release 56. r=waldo

https://hg.mozilla.org/integration/mozilla-inbound/rev/30f041ae627955109fba2f70b10533f982843c7c
Bug 1210165 - Update in-tree ICU to release 56.1. implied-rs=waldo, who reviewed the script that generates it

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc5e82ff992f3922e8d6a1e4c21b344b94c95b81
Bug 1210165 - Update normalization test data for ICU 56 (Unicode 8.0) release. rs=waldo

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f2e80134291f89635471fe75bec9a424a889c5
Bug 1210165 - Update test Intl/DateTimeFormat/format.js to expect 24-hour time in Arabic/Morocco locale. rs=waldo

https://hg.mozilla.org/integration/mozilla-inbound/rev/a53407e2b844002554266f2029f25f1bbd9bedca
Bug 1210165 - ICU update requires a CLOBBER. r=waldo
You need to log in before you can comment on or make changes to this bug.