Closed
Bug 1210408
Opened 9 years ago
Closed 9 years ago
make nsMaiInterfaceAction work with proxies
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: smaug)
References
Details
Attachments
(1 file)
|
11.93 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
the methods in nsMaiInterfaceAction.cpp need to use ProxyAccessible methods for proxied accessibles
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → bugs
Attachment #8669221 -
Flags: review?(tbsaunde+mozbugs)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8669221 [details] [diff] [review]
v1
>+void
>+AccessibleWrap::GetKeyBinding(Accessible* aAccessible, nsAString& aResult)
>+{
I'm going to assume this is an exact copy of what was in nsMaiInterfaceAction.cpp
this seems kind of gross, making this a method on Accessible seems a little nicer, but not really so whatever.
also the name doesn't seem that great its more than a key binding, but again meh whatever.
Attachment #8669221 -
Flags: review?(tbsaunde+mozbugs) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•