Closed Bug 1210408 Opened 4 years ago Closed 4 years ago

make nsMaiInterfaceAction work with proxies

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: tbsaunde, Assigned: smaug)

References

Details

Attachments

(1 file)

the methods in nsMaiInterfaceAction.cpp need to use ProxyAccessible methods for proxied accessibles
Attached patch v1Splinter Review
Assignee: nobody → bugs
Attachment #8669221 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8669221 [details] [diff] [review]
v1

>+void
>+AccessibleWrap::GetKeyBinding(Accessible* aAccessible, nsAString& aResult)
>+{

I'm going to assume this is an exact copy of what was in nsMaiInterfaceAction.cpp

this seems kind of gross, making this a method on Accessible seems a little nicer, but not really so whatever.

also the name doesn't seem that great its more than a key binding, but again meh whatever.
Attachment #8669221 - Flags: review?(tbsaunde+mozbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/2155f5b0b053
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.