Closed Bug 1210408 Opened 8 years ago Closed 8 years ago

make nsMaiInterfaceAction work with proxies

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: tbsaunde, Assigned: smaug)

References

Details

Attachments

(1 file)

v1
11.93 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review 
the methods in nsMaiInterfaceAction.cpp need to use ProxyAccessible methods for proxied accessibles
Attached patch v1 — — Splinter Review 
Assignee: nobody → bugs

        Attachment #8669221 -
        Flags: review?(tbsaunde+mozbugs)

    
    

    
  
Comment on attachment 8669221 [details] [diff] [review]
v1

>+void
>+AccessibleWrap::GetKeyBinding(Accessible* aAccessible, nsAString& aResult)
>+{

I'm going to assume this is an exact copy of what was in nsMaiInterfaceAction.cpp

this seems kind of gross, making this a method on Accessible seems a little nicer, but not really so whatever.

also the name doesn't seem that great its more than a key binding, but again meh whatever.

        Attachment #8669221 -
        Flags: review?(tbsaunde+mozbugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2155f5b0b053
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

          You need to log in
          before you can comment on or make changes to this bug.