1210513 - Direct calls don't cancel properly if you click the hangup button on the toolbar

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

Regression from bug 1184921, STR:

1) Start a direct call
2) Click the hangup button on the toolbar

Expect Results

The call stops and the window is closed.

Actual Results

The call stops, but the window stays open (and is blank).

Comment 1

[Mark Banner (:standard8)]

Attachment: Loop's direct calls don't cancel properly if you click the hangup button on the toolbar.

This fixes it for me.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8668594 [details] [diff] [review]
Loop's direct calls don't cancel properly if you click the hangup button on the toolbar.

Review of attachment 8668594 [details] [diff] [review]:
-----------------------------------------------------------------

Ooh, tricky states...

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/616c04d4e5a1

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/616c04d4e5a1

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8668594 [details] [diff] [review]
Loop's direct calls don't cancel properly if you click the hangup button on the toolbar.

Approval Request Comment
[Feature/regressing bug #]: Bug 1184921 (approval reqd for 43)
[User impact if declined]: Clicking the hangup button doesn't end a direct call properly so the user ends up with a blank window, and the peer may get notified incorrectly.
[Describe test coverage new/current, TreeHerder]: Landed in m-c with unit tests.
[Risks and why]: Low, handles a missing case.
[String/UUID change made/needed]: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8668594 [details] [diff] [review]
Loop's direct calls don't cancel properly if you click the hangup button on the toolbar.

Fixes recent regression, includes a new test. Approved for uplift to aurora.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c88c4270076

Comment 9

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

Based on bug 1212083, direct calls are no longer possible so there is no point verifying this thus removing qe-verify+.