Display only commits and only relevant data

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: MozReview Integration
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There are currently two confusing factors in the MozReview table:

* Parents are displayed, and we want to discourage reviews on them.
* The submitter is only displayed as part of the cryptic parent summary.
* The status field is very Review Board specific and not useful.

Thus we should take out the parent row altogether, add a submitter column (ideally a standard BMO user widget, but at least an IRC nick), and remove the status column.
(Assignee)

Comment 1

2 years ago
Screenshot at https://reviewboard.mozilla.org/r/21059/, with submitter nicks in plain text.
(Assignee)

Comment 2

2 years ago
Created attachment 8668815 [details] [diff] [review]
Simplify MozReview table

Had to add some !important CSS attributes sadly, but saw no way around it.

As discussed, has text-only submitter nicks.  Full UI is pending templatification of the user widget.
Attachment #8668815 - Flags: review?(glob)
(Assignee)

Comment 3

2 years ago
Heh I guess that's three confusing factors, in the end.
Comment on attachment 8668815 [details] [diff] [review]
Simplify MozReview table

Review of attachment 8668815 [details] [diff] [review]:
-----------------------------------------------------------------

having the submitter in its own column appears to waste a lot of horizontal space for most bugs (where the same person submitted all patches), but given one of the goals here is to remove that header row it's probably the best we can do.

::: extensions/MozReview/web/js/mozreview.js
@@ +96,2 @@
>                  for (j = 0; j < family.children.length; j++) {
> +                    tbody.append(rrCommitRow(family.children[j], j==0));

nit: missing spaces around ==
Attachment #8668815 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   6cbec76..4681573  master -> master

and somehow i forgot to fix the == nit before committing this for you:

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   4681573..200cbd8  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.