1210725 - Set proper audience in SyncManager.getAssertion.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We are currently sending {"exp":2232175968017,"aud":"[System Principal]"} in the BID assertions generated from SyncManager. [System Principal] should be https://token.services.mozilla.com/ instead.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1210725.tokenserveraudience > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Gecko fix

I am filling a bug to improve the b2g/components/test/unit/test_fxaccounts.js tests.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Bug 1210732

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8668873 [details] [diff] [review]
Gecko fix

let audience = msg.audience || data.audience || principal.originNoSuffix;

would be safer, but if you're sure that nobody is using the functionality of passing msg.audience, then removing it is a nice cleanup.

I think I'm not a peer for this code, but if you're sure msg.audience is unused, then LGTM/r+/as you see fit. :)

Comment 5

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8668872 [details] [review]
[gaia] ferjm:bug1210725.tokenserveraudience > mozilla-b2g:master

Maybe you can add a unit test for your change.

Otherwise, I'm not a system app peer, but LGTM/r+/as you see fit.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68d8bca34e9953731f4d59366a1f025bbecd9634
Bug 1210725 - Set proper audience in SyncManager.getAssertion. r=michielbdjong

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Gaia: https://github.com/mozilla-b2g/gaia/commit/d0856c669abfc4af1265a5f6936f0fa52d7d02ab

I added the unit test as you suggested.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68d8bca34e99