Closed Bug 1210743 Opened 5 years ago Closed 4 years ago

[Marionette] Remove waiting for "system-message-listener-ready" on B2G/emulator

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(1 file)

Waiting for "system-message-listener-ready" on B2G was added in order to pass telephony tests [1]. However, after bug 815526, Telephony module is no longer dependent on this event, theoretically, we can pass telephony marionette-webapi tests without waiting this event, too.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=792647
Attached patch WIP, Patch, v1Splinter Review
I remember I got failure on some tests, but I can not find the try link (maybe I was testing locally).
Let me just push to try again, https://treeherder.mozilla.org/#/jobs?repo=try&revision=aab0244cde68.
(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8672514 [details] [diff] [review]
> WIP, Patch, v1
> 
> I remember I got failure on some tests, but I can not find the try link
> (maybe I was testing locally).

A clever trick I learned some time ago is that you can click your username in Treeherder to get all one’s pushes, for example https://treeherder.mozilla.org/#/jobs?repo=try&author=echen@mozilla.com.
I think waiting for this event acts as a proxy for waiting for startup to be finished; if we remove it, it's probably needed to add some other kind of wait.
Closing out B2G related bugs. If these still happen and are valuable, please reopen with details again and how this affects Desktop/Fennec
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.