1210995 - TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_system_update.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Kent James (:rkent)]

Started with nightly builds Thu Oct 1, 4:14:00

Comment 1

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* comm-central: 6

Platform breakdown:
* linux32: 3
* windowsxp: 1
* windows7-32: 1
* linux64: 1

For more details, see:
http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210995&startday=2015-09-28&endday=2015-10-04&tree=all

Comment 2

[Magnus Melin [:mkmelin]]

Hmm, times don't really add up to be a direct fallout from bug 1212059, but after 1212059 it would fail yes.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1210995_test_system_update.patch

Disable these tests when addon-signing isn't in use. (As Thunderbird currently do not require signing - bug 1168571)

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8686776 [details] [diff] [review]
bug1210995_test_system_update.patch

Review of attachment 8686776 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is a failure we should just ignore. It is very important that we have some signature verification of system add-on updates even if add-on signing in general is ignored (Thunderbird might want to use this feature in the future or Firefox might disable signing at some future point).

I think instead we need to change verifyZipSignedState and verifyDirSignedState to still validate signatures for add-ons in the system update location regardless of the signing requirement settings. I'm happy to write that patch if you like it just may take a couple of days.

Comment 5

[Magnus Melin [:mkmelin]]

Thx, assigning to you