1225629 - Always verify signatures for hotfixes and system add-on updates

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

When signature verification is completely bypassed for regular add-ons (as in Thunderbird) we should still be verifying signatures for Mozilla shipped app updates like hotfixes and system add-ons.

Comment 1

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1225629: Always verify signatures for hotfixes and system add-on updates. r?rhelmer

Bug 1225629: Always verify signatures for hotfixes and system add-on updates. r?rhelmer

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8688656 [details]
MozReview Request: Bug 1225629: Always verify signatures for hotfixes and system add-on updates. r?rhelmer

https://reviewboard.mozilla.org/r/25371/#review22959

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f6d225ad273d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6d225ad273d

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8688656 [details]
MozReview Request: Bug 1225629: Always verify signatures for hotfixes and system add-on updates. r?rhelmer

Approval Request Comment
[User impact if declined]: dev edition can't be hotfixed, and verification issues with system add-ons when add-on signing isn't enabled
[Describe test coverage new/current, TreeHerder]: thunderbird (where add-on signing is disabled atm) tests became green after the fix. 
[Risks and why]: 
[String/UUID change made/needed]: none

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8688656 [details]
MozReview Request: Bug 1225629: Always verify signatures for hotfixes and system add-on updates. r?rhelmer

Adds test coverage, also, We want to be able to hotfix aurora. 
Please uplift to aurora and beta.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1d414d707af3

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to do some fudging in the test to uplift it to beta, but mossop says it was alright to do:
https://hg.mozilla.org/releases/mozilla-beta/rev/ca8e41ac5c2b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Less alright than I'd like, the test broke: https://treeherder.mozilla.org/logviewer.html#?job_id=654661&repo=mozilla-beta

Backed out in https://hg.mozilla.org/releases/mozilla-beta/rev/64f08f88a6ab

Comment 10

[Dave Townsend [:mossop]]

I had to do some different fudging because bug 1212059 isn't fixed on beta so we always expect system add-ons to be signed regardless.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ec61f4c9fe0