When opening a toolbox targeting a worker / service worker, the title is `Debugger (null)`

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Created attachment 8669190 [details]
debugger-toolbox-title.png

STR:

Enable devtools.debugger.workers
Open http://bgrins.github.io/devtools-demos/worker/webworker.html
Open debugger and click on one of the workers

A toolbox opens and the title is "Debugger (null)".  It should probably have the source name parenthesized (or nothing at all!).

See screenshot
(Assignee)

Updated

2 years ago
Blocks: 943220
(Assignee)

Comment 1

2 years ago
Created attachment 8669210 [details] [diff] [review]
toolbox-title.patch

WIP, needs a test
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8669242 [details]
MozReview Request: Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel
Attachment #8669242 - Flags: review?(ejpbruel)
(Assignee)

Comment 3

2 years ago
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Created attachment 8669242 [details]
> MozReview Request: Bug 1211017 - Show URL as the title in worker
> toolboxes;r=ejpbruel
> 
> Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Notice that the getter for `name` on the target is already handling the isAddon case that the toolbox was previously trying to do: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/target.js#381.

Also, the new test is very simple but could be expanded soon as we need to test more related stuff.  And rather than testing the new experimental worker debugger listing UI within the debugger, it's using showToolbox directly so it also covers similar the behavior that's used by the upcoming about:debugging page.
(Assignee)

Comment 4

2 years ago
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8104bc4da7a
The Browser Content Toolbox has the same problem, not sure if this patch helps there or not, see bug 1145312.
See Also: → bug 1145312
(Assignee)

Comment 6

2 years ago
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> The Browser Content Toolbox has the same problem, not sure if this patch
> helps there or not, see bug 1145312.

Just checked and it doesn't, I'm guessing whatever target it is using needs to implement a `name` or `url` property.
(Assignee)

Updated

2 years ago
No longer depends on: 1209699
Comment on attachment 8669242 [details]
MozReview Request: Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

https://reviewboard.mozilla.org/r/21165/#review19233

LGTM. Thanks for doing this Brian! This was another one of those papercuts that made me feel like the worker debugger is not production ready.
Attachment #8669242 - Flags: review?(ejpbruel) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/2ebf10394882
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ebf10394882
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Depends on: 1224302
You need to log in before you can comment on or make changes to this bug.