Closed Bug 1211017 Opened 6 years ago Closed 6 years ago

When opening a toolbox targeting a worker / service worker, the title is `Debugger (null)`

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

STR:

Enable devtools.debugger.workers
Open http://bgrins.github.io/devtools-demos/worker/webworker.html
Open debugger and click on one of the workers

A toolbox opens and the title is "Debugger (null)".  It should probably have the source name parenthesized (or nothing at all!).

See screenshot
Blocks: sw-devtools
WIP, needs a test
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel
Attachment #8669242 - Flags: review?(ejpbruel)
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Created attachment 8669242 [details]
> MozReview Request: Bug 1211017 - Show URL as the title in worker
> toolboxes;r=ejpbruel
> 
> Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Notice that the getter for `name` on the target is already handling the isAddon case that the toolbox was previously trying to do: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/target.js#381.

Also, the new test is very simple but could be expanded soon as we need to test more related stuff.  And rather than testing the new experimental worker debugger listing UI within the debugger, it's using showToolbox directly so it also covers similar the behavior that's used by the upcoming about:debugging page.
The Browser Content Toolbox has the same problem, not sure if this patch helps there or not, see bug 1145312.
See Also: → 1145312
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> The Browser Content Toolbox has the same problem, not sure if this patch
> helps there or not, see bug 1145312.

Just checked and it doesn't, I'm guessing whatever target it is using needs to implement a `name` or `url` property.
No longer depends on: 1209699
Comment on attachment 8669242 [details]
MozReview Request: Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

https://reviewboard.mozilla.org/r/21165/#review19233

LGTM. Thanks for doing this Brian! This was another one of those papercuts that made me feel like the worker debugger is not production ready.
Attachment #8669242 - Flags: review?(ejpbruel) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ebf10394882
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.