1211370 - Get "task.target is undefined" error when deleting a history record from Places DataStore.

Status: RESOLVED DUPLICATE of bug 1216394

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Sean Lee [:seanlee][:weilonge]]

When the places record is removed from Places DataStore, the following error will popup:
JavaScript error: app://search.gaiamobile.org/shared/js/sync_datastore.js, line 89: TypeError: task.target is undefined

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/sync_datastore.js#L89

after checking MDN DataStoreTask object, there is no 'target' property.
https://developer.mozilla.org/en-US/docs/Web/API/DataStoreTask
could someone give me a hint or direction how to fix it?

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Hi Dale, Ben,

Per the bug description, it will fail to remove a place record.
Could you help to see this bug? This bug will affect the history synchronization feature.
Thank you. :)

Comment 2

[Dale Harvey (:daleharvey)]

Sean, hey yup this is just using an old version of the datastore api and as it is a currently unused code path it never got updated, if you just change it to:

          case 'remove':
            var id = task.id;
            SDS.persistStore.remove(id, SDS.store.revisionId);

Then it should be fine, thanks

Comment 3

[Sean Lee [:seanlee][:weilonge]]

After apply Dale's suggestion, another error happens at [1]:
JavaScript error: app://search.gaiamobile.org/js/places_idb.js, line 88: TypeError: txn.objectStore(...).remove is not a function

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/search/js/places_idb.js#L88

Comment 4

[Sean Lee [:seanlee][:weilonge]]

After verifying the patch at bug 1216394, it does fix the issue.