1211511 - Sound indicator is displayed on vk.com while nothing is causing sound

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[arni2033]

STR:   (Win7_64, Nightly 43, 32bit, ID 20150910030225, new profile, safe mode)
0. Open   about:addons (Ctrl+Shift+A), disable Flash Plugin ("Never Activate")
1. Open   https://vk.com/video211054116_167519691
2. Click video to play it   [make sure the video starts playing and sound indicator is displayed]
3. Click outside of the video

Result:       Video is closed, <video> element is deleted, but the sound indicator is still displayed
Expectations: Shound indicator should disappear, just like in Chrome

I *checked*: it always happen when I remove [src] of any <video> and then remove <video> element

Comment 1

[Paul Adenot (:padenot)]

Andrea, maybe this is an edge case that got missed ?

Comment 2

[Andrea Marchesini [:baku]]

Attachment: notify.patch

The bug here is that NotifyStartedPlaying and NotifyStoppedPlaying are inconsistent about the notification of playback. This happens because HasAudio() returns true and then false.
With this patch NotifyStoppedPlaying follows the notification playback flag of NotifyStartedPlaying.

Comment 3

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1418f98468c3

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1418f98468c3

Comment 5

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on latest Nightly 44.0a1 (buildID: 20151011030229).