1225051 - Volume icon will not disappear if removing video src prior to calling pause

Status: RESOLVED DUPLICATE of bug 1211511

(Core :: Audio/Video, defect)

Description

[Dima Sokol]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

1. Start video playback with <video> tag
2. Programmatically remove src from <video> tag
(to release memory, popular jwplayer does the same on .stop() call)


Actual results:

Volume icon in tab will stay even after removing <video> tag


Expected results:

Volume icon should disappear

Comment 1

[:Gijs (he/him)]

Can you provide a testcase?

I tried to reproduce on http://www.quirksmode.org/html5/tests/video.html using the web console, but either removing the <source> tag while the video was playing, or first removing that, then adding a "src" attribute, then removing the attribute while the video was playing, doesn't reproduce the problem for me - the video keeps playing, and so the sound icon remains (correctly so). What am I missing?

Comment 2

[Dima Sokol]

My fault, I need to be more concrete.

"Programmatically remove src from <video> tag" I was meaning to set "src" property to "''" (empty string).

I've spent some time to explore minified source of jwplayer and found that they make it by removing "src"
attribute and then call "load()".

So you can do this in 2 ways (not sure if second one will work with <source> variant): 
1) video_tag.src='';
2) video_tag.removeAttribute('src');video_tag.load();

Comment 3

[:Gijs (he/him)]

Seems like if there's a <source> on page load, manually removing that doesn't affect playback at all. Just using:

http://jsbin.com/fifexurabo/edit?html,output

and using the browser console to reset the "src" attribute does allow me to reproduce this on beta (43).

However, this is also already fixed on Nightly, it seems. I'm trying to find a fix range so we can figure out when it started working.

Comment 4

[:Gijs (he/him)]

Fix range:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f5faa6c60e68c19eb0eb931468b2d690a67e5aa&tochange=1418f98468c37f5631a35739268dbfef5b4d4f26

This is fixed on 44 (currently developer edition) and later.