1211582 - [Contacts] Performance regression in cold launch caused by bug 1182195

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Francisco Jordano [:arcturus] [:francisco]]

In  bug 1182195 we introduced a performance regression around ~150ms cause we have a new iframe to load and the 'onload' event won't be completely triggered until that iframe has been loaded.

We don't need this iframe on the startup path. We can load it when we need to import contacts, so we could potentially append it to the dom when we open the settings section.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR

Hei Fernando, could you take a look.

We were adding the iframe with the courtain, but the curtain.js already adds it dynamically, the problem we had is that we are not picking the correct reference to 'doc', I mean, we had different references.

Don't know why adding the iframe was helping here, but it's hurting performance and we already have all the mechanism in place to add the iframe dynamically after we loaded the list.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/59fd1222da4dd2bad6a4bab13bbdeb9a4347649d

and nga branch:

https://github.com/mozilla-b2g/gaia/commit/0936168fc504b1ed2c206e431a8f0bce8236f504