1211708 - RSS feed select dropdown list background is transparent

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Alice0775 White]

Attachment: screenshot

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/b56aeea0c4701677ffda6417183caa60d2a6a4a7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 ID:20151005030206
https://hg.mozilla.org/releases/mozilla-aurora/rev/58f5e8ddaa59b31dec9938a83cc24210cb514896
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0 ID:20151005004046


Steps To Reproduce:
0. Disable e10s and restart
1. Open web page with RSS deed (E.x. https://wiki.mozilla.org/WebExtensions )
2. "Bookmarks – Subscribe to This Page…"
3. Click Select dropdown marker

Actual Results:
The dropdown list background is transparent

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c2d2b0c046a3673aa4937a921a026c8b6b3ea04a&tochange=92ba84502c36

Regressed by: Bug 1195162

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Probably some package needs to be marked as loadable from content.

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Jonas Sicking (:sicking) from comment #2)
> Probably some package needs to be marked as loadable from content.

Jonas already gave a very detailed explanation over in Bug 1205052 which is worth cross posting here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1205052#c23

Comment 4

[Kate Glazko]

Tracking in 44 Nightly because this is is a regression, is visible to users and could have potential impact.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Does the error console contain any information? What if you reload the page?

Comment 7

[Alice0775 White]

(In reply to Jonas Sicking (:sicking) from comment #6)
> Does the error console contain any information?

No error in Browser Console.

> What if you reload the page?

Nothing is changed. The problem persists.

Comment 8

[[e-mail]]

(In reply to Christoph Kerschbaumer from comment #3)
> (In reply to Jonas Sicking from comment #2)
> > Probably some package needs to be marked as loadable from content.

Comment 9

[[e-mail]]

Sorry, misclick.

(In reply to Jonas Sicking from comment #2)
> Probably some package needs to be marked as loadable from content.

There are no custom styles applied to the menupopup, its computed binding is chrome://global/content/bindings/popup.xml#popup-scrollbars which is already loadable from content (line 2 of toolkit.jar).

Is there somewhere I can breakpoint to find out why the load failed?

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hrm.. if this is already a web-exposed package then I'm not really sure what's going on. A good place to start would likely be to step through any calls to nsContentSecurityManager::doContentSecurityCheck.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

We should be tracking this in 43 as well since the regression began there. 

Looks like there is also discussion over in https://bugzilla.mozilla.org/show_bug.cgi?id=1195162#c64. 

Christoph or Jonas, this looks like a side effect of work that you all are doing; is this something you can also take on? Do you think it will be addressed by what you're already working on?  While it's a regression, it seems fairly minor in itself. So we might end up wontfixing this for 43.

Comment 12

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #11)
> We should be tracking this in 43 as well since the regression began there. 
> 
> Looks like there is also discussion over in
> https://bugzilla.mozilla.org/show_bug.cgi?id=1195162#c64. 
> 
> Christoph or Jonas, this looks like a side effect of work that you all are
> doing; is this something you can also take on? Do you think it will be
> addressed by what you're already working on?  While it's a regression, it
> seems fairly minor in itself. So we might end up wontfixing this for 43.

Thanks Liz for keeping track of things. I will have a look later this week. Leaving ni? flag for now so it gets my attention.

Comment 13

[[e-mail]]

(In reply to Jonas Sicking from comment #10)
> Hrm.. if this is already a web-exposed package then I'm not really sure
> what's going on. A good place to start would likely be to step through any
> calls to nsContentSecurityManager::doContentSecurityCheck.

I tried that but it just returns NS_OK in the case of popup.xml.

Comment 14

[[e-mail]]

The binding for the dropdown list happens to be set in the theme, rather than content. Bug 1195162 accidentally removed the ability for themes to set bindings in insecure documents.

Comment 15

[[e-mail]]

Attachment: Possible patch

This fixes it for me. I believe that this just allows the theme to specify the binding; the binding itself still needs to be accessible to content in the normal way.

Comment 16

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8683178 [details] [diff] [review]
Possible patch

Review of attachment 8683178 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a comment indicating why this is needed.

Comment 17

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Jonas Sicking (:sicking) from comment #16)
> Please add a comment indicating why this is needed.

Thanks Jonas for jumping in. Looks good - thanks for fixing.

Comment 18

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21a2e66bf784

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21a2e66bf784

Comment 20

[[e-mail]]

Comment on attachment 8683178 [details] [diff] [review]
Possible patch

Approval Request Comment
[Feature/regressing bug #]: 1195162
[User impact if declined]: Mostly display issue
[Describe test coverage new/current, TreeHerder]: Don't ask don't tell
[Risks and why]: Low, surgical backout
[String/UUID change made/needed]: None

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8683178 [details] [diff] [review]
Possible patch

Ugly visual regression, taking it.
Should be in 43 beta 2.

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f250ff2ead10

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a56a93a6292

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f250ff2ead10

Comment 25

[Ada [:adalucinet]]

Reproduced with Nightly from 2015-10-03.
Verified fixed with latest 44.0a2 (from 2015-11-10) and 45.0a1 (from 2015-11-09), across platforms [1].

[1] Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit