Closed Bug 1211718 Opened 4 years ago Closed 4 years ago

Remove address field from notification permissions dialog

Categories

(Firefox :: Preferences, defect)

44 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: wmaggs, Assigned: jaws)

References

Details

User Story

Acceptance Criteria

1. User can view and change preferences via the manual interface 
2. User must type exact domain (http vs. https, etc) to be able to change preference. 
3. Check that changing the preference is immediately recognized by the site.

Attachments

(1 file, 2 obsolete files)

The initial UI for centralized management of Notifications in Firefox currently follows the code and pattern of PopUp Preferences, and should be adjusted to allow the user to easily manage prefs for multiple sites. 

1. Remove the manual input field at the top. It doesn't do much that is useful. 

2. Change the text at the top to read: 

You can specify the sites that are allowed to send or blocked from sending notifications. Removing a site from the list resets the preference to the default, which is to ask to send notifications. 

3. Toggle each entry in the list view between Allow and Block on mouse click. 

4. Replace the string for button saying "Remove" with "Reset." We could also make the string "Reset (Ask). Another alternative would be to retain the Remove string, but add a tooltip that explains that removing a site from the list resets to default which is to Ask. The text at the top also explains this. 

5. The Remove/Reset All button can remain. 


6. Finally, the Do Not Disturb check box has still to land on the Content Preferences Pane in a separate bug.
Flags: needinfo?(philipp)
(In reply to Bill Maggs (bmaggs) from comment #0)
> 1. Remove the manual input field at the top. It doesn't do much that is
> useful. 

The manual input field at the top is how the user preemptively Blocks a site (or preemptively Allows, though more rare). If we removed that field at the top, then we would only be supporting "Remove" aka Reset.
Thanks for the summary Bill! A few edits inline…

(In reply to Bill Maggs (bmaggs) from comment #0)
> The initial UI for centralized management of Notifications in Firefox
> currently follows the code and pattern of PopUp Preferences, and should be
> adjusted to allow the user to easily manage prefs for multiple sites. 
> 
> 1. Remove the manual input field at the top. It doesn't do much that is
> useful. 
> 
> 2. Change the text at the top to read: 
> 
> You can specify the sites that are allowed to send or blocked from sending
> notifications. Removing a site from the list resets the preference to the
> default, which is to ask to send notifications.

This feels pretty long and complicated to me. How about this:
»These websites want to send you notifications even while you are not visiting them. Double click a row to allow/block a site from sending you notifications in the future.«

I have also put this in the mockup.

> 3. Toggle each entry in the list view between Allow and Block on mouse
> click. 

Let's do this on double click, since a single click into a list is reserved for selecting the item.

> 4. Replace the string for button saying "Remove" with "Reset." We could also
> make the string "Reset (Ask). Another alternative would be to retain the
> Remove string, but add a tooltip that explains that removing a site from the
> list resets to default which is to Ask. The text at the top also explains
> this. 
> 
> 5. The Remove/Reset All button can remain. 
> 
> 
> 6. Finally, the Do Not Disturb check box has still to land on the Content
> Preferences Pane in a separate bug.

The mockup of record is here:
https://mozilla.invisionapp.com/d/main#/console/4778016/104947124/preview
Flags: needinfo?(philipp)
(In reply to Philipp Sackl [:phlsa] (Firefox UX) please use needinfo from comment #2)
> The mockup of record is here:
> https://mozilla.invisionapp.com/d/main#/console/4778016/104947124/preview

This link is password-protected.
Flags: needinfo?(philipp)
Consensus appears to be lower left button string should be "Reset Permission(Ask)" and lower right button string should be "Reset All." 

Should there still be a tooltip?
I'm personally not really convinced that changing the button string adds clarity. Currently it's clear that when I click the button it will remove the row from the table (which is a list of permission granted/denied). It's less clear to me what Reset means… it actually feels more like jargon.
User Story: (updated)
Summary: Updated Notification Preferences Management Interface in Content Preferences → Remove address field from notification permissions dialog
I agree with comment #5. With the address bar removed, "Remove site" will be even clearer.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Attached patch Patch (obsolete) — Splinter Review
This capability was already present but we weren't using it. I added a test that confirms that the url field is hidden for the notification permissions but visible for the popup permissions.
Attachment #8676558 - Flags: review?(MattN+bmo)
Comment on attachment 8676558 [details] [diff] [review]
Patch

Review of attachment 8676558 [details] [diff] [review]:
-----------------------------------------------------------------

Glad this was already supported :) You forgot to replace the "notificationspermissionstext" string though.
Attachment #8676558 - Flags: review?(MattN+bmo) → feedback+
Attached patch Patch v1.1 (obsolete) — Splinter Review
Thanks for catching that! Now with simplified text.
Attachment #8676558 - Attachment is obsolete: true
Attachment #8676608 - Flags: review?(MattN+bmo)
Comment on attachment 8676608 [details] [diff] [review]
Patch v1.1

Review of attachment 8676608 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/preferences/preferences.properties
@@ +24,5 @@
>  addonspermissionstext=You can specify which websites are allowed to install add-ons. Type the exact address of the site you want to allow and then click Allow.
>  addons_permissions_title=Allowed Sites - Add-ons Installation
>  popuppermissionstext=You can specify which websites are allowed to open pop-up windows. Type the exact address of the site you want to allow and then click Allow.
>  popuppermissionstitle=Allowed Sites - Pop-ups
> +notificationspermissionstext2=You can remove which websites are always or never allowed to show notifications.

Should we add the second sentence from https://mozilla.invisionapp.com/share/3A4A895XZ#/screens/104947124 with s/reset/remove/?
Attachment #8676608 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/bb1a2ca11712
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.