1205172 - Do Not Disturb Button for Push Notifications on Windows

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Bill Maggs (bmaggs)]

Push Notifications on Windows desktop need a Do Not Disturb button or control to be able to quickly turn off messages being received for some period of time without revoking all permissions to receive or show Push Notifications. This functionality is provided by the Notification Center on OSX, and is a feature of Chrome Notifications on all desktop platforms.  

The feature may exist within Preferences but needs to be discoverable from the UI, preferably from the platform UI (system bar), so that users do not have to bring up Firefox to use it.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.2

I added a call to create a second notification in the test and confirm that it doesn't appear.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8673143 [details] [diff] [review]
Patch v1.2

Review of attachment 8673143 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/alerts/browser_notification_do_not_disturb.js
@@ +1,3 @@
> +/* Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/publicdomain/zero/1.0/
> + */

Nit: not necessary

use add_task in the future (probably with shared helpers returning promises)

::: toolkit/components/alerts/resources/content/alert.js
@@ +244,5 @@
>    }
>  }
>  
> +function doNotDisturb() {
> +  const alertService = Cc["@mozilla.org/alerts-service;1"]

You may need to stopPropagation on the event so that alertclickcallback doesn't also get called (focusing the tab and telling the page). Adding this to the test would be good if that's the case.

@@ +255,2 @@
>  function disableForOrigin() {
>    if (gPrincipal) {

Ditto

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4fdcfcac18c7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fdcfcac18c7