121176 - walking through thread pane with preview collapsed should set title to folder name

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

mozilla currently wastes my eye cycles changing the window title to match the 
message while the preview is collapsed. this is annoying and makes it hard for 
me to find the folder i was browsing by checking the taskbar.

Comment 1

[jglick]

I agree. 

http://www.mozilla.org/mailnews/specs/threepane/#Title

"If a particular message has not yet been selected, or the "Message" pane is 
closed, the <Subject> would be omitted from the examples above where 
appropriate."

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[[e-mail]]

Patch collision - Bug 127409's patch got mixed in, sorry :-)

Comment 4

[[e-mail]]

Attachment: Fixed setting the title when uncollapsing

Fortunately gDBView.reloadMessage will do nothing when I'm collapsing the pane.

However it's the only way I could figure out to set the title.
I really need to call nsMsgDBView::UpdateDisplayMessage but that's only called
either from LoadMsgByMsgKeyHelper which is called by ReloadMessage, or from
ndMsgDBView::SelectionChanged, but I can't get that case to work :-(

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 95572 [details] [diff] [review]
Fixed setting the title when uncollapsing

r+sr=dmose

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[[e-mail]]

Attachment: Fix grippy clicking

I was having issues with grippy clicking because I was seeing too many events.
I also switched back to selectionChanged as it seems to be more reliable.

Comment 8

[Karsten Düsterloh]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

Can you elaborate a bit on what exactly this patch is about to fix? What "issues" did you run into?

Comment 9

[Karsten Düsterloh]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

Okay, so ChangeMessagePaneVisibility is now only called once when toggling the message pane, and the error seen in 314301 is gone, too. :)

Comment 10

[[e-mail]]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

Note: I'm not convinced many people do this, so it won't have got much testing

Comment 11

[Robert Kaiser]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

a=me given none of the touched files is shared with Thunderbird...

Comment 12

[Ian Neal]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

Re-requesting approval for branches as this never got checked into the branch.

Comment 13

[Robert Kaiser]

Comment on attachment 200995 [details] [diff] [review]
Fix grippy clicking

Given there are no other objections since I did that last time, a=me again for 1.8-based code :)

Comment 14

[Ian Neal]

Attachment: Combined patch for branches (Checked in 1.8 & 1.8.0 branches)

This is the equivalent combined patch for either of the branches.

Comment 15

[Ian Neal]

Comment on attachment 217700 [details] [diff] [review]
Combined patch for branches (Checked in 1.8 & 1.8.0 branches)

Checking in (1.8 branch)
commandglue.js;
new revision: 1.258.4.6; previous revision: 1.258.4.5
mail3PaneWindowVertLayout.xul;
new revision: 1.106.2.4; previous revision: 1.106.2.3
messenger.xul;
new revision: 1.258.2.4; previous revision: 1.258.2.3
threadPane.js;
new revision: 1.80.4.5; previous revision: 1.80.4.4
widgetglue.js;
new revision: 1.171.4.1; previous revision: 1.171
done

Checking in (1.8.0 branch)
commandglue.js;
new revision: 1.258.10.6; previous revision: 1.258.10.5
mail3PaneWindowVertLayout.xul;
new revision: 1.106.2.1.2.3; previous revision: 1.106.2.1.2.2
messenger.xul;
new revision: 1.258.2.1.2.3; previous revision: 1.258.2.1.2.2
threadPane.js;
new revision: 1.80.12.2; previous revision: 1.80.12.1
widgetglue.js;
new revision: 1.171.12.1; previous revision: 1.171
done