121188 - Remove references to dialogOverlay.css in allskin.xul, embed-jar.mn

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[John Morrison]

This came up in looking at bug 121057. It's a simple cleanup task.
There is no file 'dialogOverlay.css' anymore (I don't know when this
changed). A query for 
 http://lxr.mozilla.org/seamonkey/search?string=dialogoverlay.css
turns up these references to it:


/extensions/inspector/resources/content/tests/allskin.xul, line 7 -- 
<?xml-stylesheet href="chrome://communicator/skin/dialogOverlay.css"?>
/extensions/inspector/resources/content/tests/allskin.xul, line 43 -- 
<?xml-stylesheet href="chrome://global/skin/dialogOverlay.css"?>
/embedding/config/embed-jar.mn, line 16 -- 
skin/classic/communicator/dialogOverlay.css, 
classic/skin/classic/communicator/dialogOverlay.css 
/xpfe/components/prefwindow/resources/content/pref-scripts.xul, line 39 -- 
<?xml-stylesheet
href="chrome://communicator/skin/dialogOverlay.css" type="text/css"?>

The one in pref-scripts.xul will be removed for bug 121057. The other two 
should be removed as well, at your leisure.

Comment 1

[Anne (:annevk)]

There are actually some files:
 <http://lxr.mozilla.org/seamonkey/find?string=dialogOverlay.css>

Do those references still need to be removed?

Comment 2

[Javi Rueda :javirid]

Attachment: Removing reference to dialogOverlay.css in files for directory /calendar in SeaMonkey repository.

Comment 3

[Javi Rueda :javirid]

Attachment: Bug 121188 - Remove references to dialogOverlay.css for the DOM Inspector [Checkin: comment 12]

Untested

Comment 4

[[e-mail]]

Comment on attachment 560096 [details] [diff] [review]
Bug 121188 - Remove references to dialogOverlay.css for the DOM Inspector [Checkin: comment 12]

Looks like dialogOverlay.css went away with bug 70750.

Comment 5

[Javi Rueda :javirid]

Before review-granted patches are check-in their trees, these are the results when searching for dialogOverlay.css, reordered for the following comment:

http://mxr.mozilla.org/seamonkey/search?string=dialogoverlay.css

Found 6 matching lines in 5 files

/extensions/inspector/resources/content/tests/allskin.xul (View CVS log or CVS annotations)
line 7 -- <?xml-stylesheet href="chrome://communicator/skin/dialogOverlay.css"?>
line 41 -- <?xml-stylesheet href="chrome://global/skin/dialogOverlay.css"?>
/calendar/resources/jar.mn (View CVS log or CVS annotations)
line 32 -- skin/classic/calendar/dialogOverlay.css (skin/classic/dialogOverlay.css)
/calendar/resources/content/publishDialog.xul (View CVS log or CVS annotations)
line 43 -- <?xml-stylesheet href="chrome://calendar/skin/dialogOverlay.css" type="text/css"?>

/embedding/config/embed-jar.mn (View CVS log or CVS annotations)
line 25 -- skin/classic/communicator/dialogOverlay.css, classic/skin/classic/communicator/dialogOverlay.css
/calendar/resources/content/printDialog.xul (View CVS log or CVS annotations)
line 49 -- <?xml-stylesheet href="chrome://calendar/skin/dialogOverlay.css" type="text/css"?>

First group of files will be patched from here. They reside in the comm-central Mercurial repository.

Files in /embedding and printDialog.xul are in closed trees. Both of them reside  CVS repository of SeaMonkey.

Comment 6

[Tony Mechelynck [:tonymec]]

That search is in an obsolete repository — CVS is dead, at least for current SeaMonkey builds.
SeaMonkey trunk builds are from the following 6 Mercurial repositories:
http://hg.mozilla.org/comm-central/
http://hg.mozilla.org/mozilla-central/
http://hg.mozilla.org/chatzilla/
http://hg.mozilla.org/dom-inspector/
http://hg.mozilla.org/projects/ldap-sdks/
http://hg.mozilla.org/venkman/

Comment 7

[Javi Rueda :javirid]

Attachment: patch for bug 121188 - dir /calendar

Comment 8

[Javi Rueda :javirid]

(In reply to Tony Mechelynck [:tonymec] from comment #6)
> That search is in an obsolete repository — CVS is dead, at least for current
> SeaMonkey builds.
> SeaMonkey trunk builds are from the following 6 Mercurial repositories:
> http://hg.mozilla.org/comm-central/
> http://hg.mozilla.org/mozilla-central/
> http://hg.mozilla.org/chatzilla/
> http://hg.mozilla.org/dom-inspector/
> http://hg.mozilla.org/projects/ldap-sdks/
> http://hg.mozilla.org/venkman/

Thank you very much, Tony. I have searched again in the repositories. This time I have used the MXR tool but only with /comm-central, /mozilla-central and /projects.

Extensions ChatZilla, DOM Inspector and venkman appeared in the /comm-central and the query in /projects returned no results.

Comment 9

[Philipp von Weitershausen [:philikon]]

Comment on attachment 560431 [details] [diff] [review]
patch for bug 121188 - dir /calendar

You probably meant to ask Philipp Kewisch for review? :)

Comment 10

[Javi Rueda :javirid]

(In reply to Philipp von Weitershausen [:philikon] from comment #9)
> 
> You probably meant to ask Philipp Kewisch for review? :)

Oh. Sorry, yeah.

Comment 11

[Javi Rueda :javirid]

In order to close the bug, cancelling the petition to review the patch for the calendar component and resetting the title (which I changed) to the original one.

Asking for check-in the positively reviewed patch.

The patch for the calendar component is not bitroded yet, so I am going to try to post a new bug about this and asking for a review.

Comment 12

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 560096 [details] [diff] [review]
Bug 121188 - Remove references to dialogOverlay.css for the DOM Inspector [Checkin: comment 12]

http://hg.mozilla.org/dom-inspector/rev/65e62d44a0e0

Leaving it up to you to close the bug.

Comment 13

[Javi Rueda :javirid]

Resolving fixed because http://mxr.mozilla.org/comm-central/search?string=dialogOverlay.css&find=%2Fmozilla%2Fextensions%2Finspector%2F&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=comm-central returned no results.