Closed Bug 1212035 Opened 9 years ago Closed 9 years ago

Intermittent browser_notification_open_settings.js | leaked 1 window(s) until shutdown [url = about:preferences#content]

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: KWierso, Assigned: lina)

References

Details

(Keywords: intermittent-failure)

Flags: needinfo?(kcambridge)
Flags: needinfo?(MattN+bmo)
Does that mean we aren't waiting for the window to close? In https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/alerts/browser_notification_open_settings.js, should the last line be `yield BrowserTestUtils.removeTab(tab)`? Looks like it returns a promise.

I can look more tonight, unless :MattN beats me to it.
(In reply to Kit Cambridge [:kitcambridge] (PTO from 2015-10-06 to 2015-10-16) from comment #3)
> Does that mean we aren't waiting for the window to close?
Yep, you're right!

> In
> https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/alerts/browser_notification_open_settings.js, should the last line be `yield
> BrowserTestUtils.removeTab(tab)`? Looks like it returns a promise.

Yep, I'll push a patch with you as the author.
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
No longer depends on: 1192458
Flags: needinfo?(MattN+bmo)
Blocks: 1208295
No longer depends on: 1208295
https://hg.mozilla.org/mozilla-central/rev/36082e2aea9c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.