1208295 - OS X: Show an additional action to open notification settings

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Matthew N. [:MattN]]

There should be a "Notification settings" additional action to open the Firefox notification settings pane to manage which sites have the notification permission.

We don't need to implement our own Do Not Disturb for OS X since the OS already provides that functionality.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1208295 - Redispatch alertsettingscallback so UI can open notification settings. r=nsm,wchen

Bug 1208295 - Redispatch alertsettingscallback so UI can open notification settings. r=nsm,wchen

Comment 2

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1208295 - Show an additional action on OS X notifications to open notification settings. r=mstange

Bug 1208295 - Show an additional action on OS X notifications to open notification settings. r=mstange

Comment 3

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1208295 - Open content preferences after receiving alertsettingscallback. r=jaws

Bug 1208295 - Open content preferences after receiving alertsettingscallback. r=jaws

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8665789 [details]
MozReview Request: Bug 1208295 - Redispatch alertsettingscallback so UI can open notification settings. r=nsm,wchen

https://reviewboard.mozilla.org/r/20349/#review18291

::: dom/notification/Notification.cpp:1171
(Diff revision 1)
> +    obs->NotifyObservers(mPrincipal, "alertsettingscallback", nullptr);

I think this should have a nicer name considering it is on the global bus. `Notifications:LaunchSettings`?

Also, can we have telemetry from the get go for these. Not necessarily in this patch, but soon.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8665790 [details]
MozReview Request: Bug 1208295 - Show an additional action on OS X notifications to open notification settings. r=mstange

https://reviewboard.mozilla.org/r/20351/#review18305

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8665791 [details]
MozReview Request: Bug 1208295 - Open content preferences after receiving alertsettingscallback. r=jaws

https://reviewboard.mozilla.org/r/20353/#review18325

::: browser/components/nsBrowserGlue.js:279
(Diff revision 1)
> +      case "alertsettingscallback":
> +        this._openPreferences("content");
> +        break;

This should open the "content" pane of the preferences, but I don't see anything there for notification settings.

Is there a separate bug that is adding this?

Comment 7

[Matthew N. [:MattN]]

https://reviewboard.mozilla.org/r/20353/#review18325

> This should open the "content" pane of the preferences, but I don't see anything there for notification settings.
> 
> Is there a separate bug that is adding this?

Yes, that is bug 1201398.

Comment 8

[Matthew N. [:MattN]]

https://reviewboard.mozilla.org/r/20349/#review18291

> I think this should have a nicer name considering it is on the global bus. `Notifications:LaunchSettings`?
> 
> Also, can we have telemetry from the get go for these. Not necessarily in this patch, but soon.

OK, I debated about changing the name but thought consistency with the existing name would be better.

Bill Maggs is working on a plan for telemetry for 44.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/04f2a2c320a3
https://hg.mozilla.org/integration/fx-team/rev/3242ff9a86bb
https://hg.mozilla.org/integration/fx-team/rev/1c16e9f4aa2f

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This caused bustage in bc7: https://treeherder.mozilla.org/logviewer.html#?job_id=4850311&repo=fx-team
Backed out in https://hg.mozilla.org/integration/fx-team/rev/e34f9feccd3f

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a5907e5982a8
https://hg.mozilla.org/integration/fx-team/rev/54f38580e0b8
https://hg.mozilla.org/integration/fx-team/rev/ba930740225e

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for build bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=4986124&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/ef7862638f95

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1810597e4ef1
https://hg.mozilla.org/integration/fx-team/rev/c0120bcd3199
https://hg.mozilla.org/integration/fx-team/rev/72400d78e78f

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1810597e4ef1
https://hg.mozilla.org/mozilla-central/rev/c0120bcd3199
https://hg.mozilla.org/mozilla-central/rev/72400d78e78f