Closed
Bug 1212074
Opened 10 years ago
Closed 10 years ago
Remove the tab headers from the panel
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox44 verified)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | verified |
People
(Reporter: standard8, Assigned: dcritchley)
References
Details
(Whiteboard: [web sharing])
User Story
Acceptance criteria: - Tab headers are no longer present on the panel. - The conversations view is always shown. Engineering notes: - In this bug, *only* remove the views associated with the tabs. Do not remove views relating to contacts, they'll be removed by a different bug. -- Main views to remove: TabView & Tab from panel.jsx. - Remove associated css - Remove unused strings associated with the tab views from the loop.properties file.
Attachments
(3 files)
|
38.88 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
|
157.17 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
|
7.59 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Screen Shot showing tabs removed
As part of the user journey work, we're removing the tab headers from the panel. See user story for more details.
Note: This bug is not intended to remove all unused code cause by removing the tab headers. Only the tabs themselves. This is a starter, and follow-on work can then happen in parallel to remove the other code.
|
Reporter | |
Updated•10 years ago
|
Rank: 11
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → david.critchley
|
|
Assignee | |
Comment 1•10 years ago
|
||
Removing Rooms and Conversation tabs from panel
Attachment #8671009 -
Flags: review?(standard8)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8671036 -
Flags: ui-review?(sfranks)
|
||
Updated•10 years ago
|
Attachment #8671036 -
Flags: ui-review?(sfranks) → ui-review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8671009 [details] [diff] [review]
Attachment to Bug 1212074 - Remove the tab headers from the panel
Review of attachment 8671009 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, so this is good, apart from the one minor comment, and the fact that it breaks mochitests. To help move this along however, I've created a patch for the mochitests that I'll attach in a moment.
::: browser/components/loop/content/css/panel.css
@@ +18,5 @@
> font: menu;
> background-color: #fbfbfb;
> height: 410px;
> width: 330px;
> + width: 330px;
Duplicated entry somehow, we don't need this extra line.
|
|
Reporter | |
Comment 4•10 years ago
|
||
This updates the mochitests and the ui tour code for the tab removals.
Attachment #8671241 -
Flags: review?(mdeboer)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8671009 -
Flags: review?(standard8) → review+
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8671241 [details] [diff] [review]
Update Mochitests for Loop now that the tabs are removed from the panel.
Review of attachment 8671241 [details] [diff] [review]:
-----------------------------------------------------------------
Somewhat sad to see this all go away, but... meh.
Attachment #8671241 -
Flags: review?(mdeboer) → review+
|
|
Reporter | |
Updated•10 years ago
|
Iteration: --- → 44.2 - Oct 19
Points: --- → 2
https://hg.mozilla.org/mozilla-central/rev/68339e68accb
https://hg.mozilla.org/mozilla-central/rev/7c76e3d8a997
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•10 years ago
|
Flags: qe-verify+
QA Contact: bogdan.maris
I can confirm that the tab headers were successfully removed without braking anything else in latest Nightly 44.0a1 across platforms (Windows 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5).
You need to log in
before you can comment on or make changes to this bug.
Description
•