Closed Bug 1212149 Opened 10 years ago Closed 10 years ago

Please implement e10s support for opening notification settings (alertsettingscallback)

Categories

(Core :: DOM: Push Subscriptions, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
e10s + ---
firefox44 --- fixed

People

(Reporter: edwong, Assigned: lina)

References

Details

Attachments

(1 file)

this is the e10s version of this bug 1208295 STR: 0. in nightly enable e10s 1. goto: https://people.mozilla.org/~ewong2/push-notification-test/ 2. click pop notification 3. in permissions dialog 'allow' 4. on mac, click on the '...' and select 'disable notifications for this site' (windows to be implemented) 5. click on the padlock to see permissions actual: site permissions say 'allow' expected: should say 'block', this works on non-e10s
Depends on: 1212129
Component: Notifications and Alerts → DOM
No longer depends on: 1212129
Product: Toolkit → Core
See Also: → 1212129
Summary: Please implement e10s support for notification UI controls → Please implement e10s support for opening notification settings (alertsettingscallback)
Blocks: 1201571
Component: DOM → DOM: Push Notifications
tracking-e10s: --- → +
NI for tracking - this is higher priority than 1210211
Flags: needinfo?(wchen)
Assignee: nobody → kcambridge
Flags: needinfo?(wchen)
Bug 1212149 - e10s support for opening notification settings. r?wchen
Attachment #8676594 - Flags: review?(wchen)
Comment on attachment 8676594 [details] MozReview Request: Bug 1212149 - e10s support for opening notification settings. r?wchen Bug 1212149 - e10s support for opening notification settings. r?wchen
Comment on attachment 8676594 [details] MozReview Request: Bug 1212149 - e10s support for opening notification settings. r?wchen https://reviewboard.mozilla.org/r/22763/#review20515 ::: dom/ipc/ContentParent.h:759 (Diff revision 1) > + bool HasNotificationPermission(const IPC::Principal& aPrincipal) const; It looks like you can make this a static function in ContentParent.cpp since it's not called elsewhere. ::: dom/notification/Notification.cpp:1142 (Diff revision 1) > + nsCOMPtr<nsIObserverService> obs = mozilla::services::GetObserverService(); Assertion for parent process. Also, can we move this method to the Notification class?
Attachment #8676594 - Flags: review?(wchen) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: