Closed Bug 1212186 Opened 4 years ago Closed 4 years ago

Disable 'layout.word_select.eat_space_to_next_word' in carets marionette tests

Categories

(Core :: DOM: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I often find myself wrote a marionette test for AccessibleCaret and see it fail on Windows after pushing it to try because of the spaces being selected after the word.

To get the same word selection behavior across all platforms for carets test, I would like to disable 'layout.word_select.eat_space_to_next_word'. In this way, we don't need to worry about the spaces being selected on Windows.
Bug1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

To get the same behavior across all platforms for carets test, disable
'layout.word_select.eat_space_to_next_word'. In this way, we don't need
to worry about the spaces being selected on Windows, and those strip()
in individual tests can be eliminated.
Attachment #8670605 - Flags: review?(mtseng)
Comment on attachment 8670605 [details]
MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

https://reviewboard.mozilla.org/r/21415/#review19291
Attachment #8670605 - Flags: review?(mtseng) → review+
Blocks: 1207934
Blocks: 1200364
Comment on attachment 8670605 [details]
MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

To get the same behavior across all platforms for carets test, disable
'layout.word_select.eat_space_to_next_word'. In this way, we don't need
to worry about the spaces being selected on Windows, and those strip()
in individual tests can be eliminated.
Attachment #8670605 - Attachment description: MozReview Request: Bug1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng → MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng
https://hg.mozilla.org/mozilla-central/rev/db9f90128b15
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.