Disable 'layout.word_select.eat_space_to_next_word' in carets marionette tests

RESOLVED FIXED in Firefox 44

Status

()

Core
Selection
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I often find myself wrote a marionette test for AccessibleCaret and see it fail on Windows after pushing it to try because of the spaces being selected after the word.

To get the same word selection behavior across all platforms for carets test, I would like to disable 'layout.word_select.eat_space_to_next_word'. In this way, we don't need to worry about the spaces being selected on Windows.
(Assignee)

Comment 1

2 years ago
Created attachment 8670605 [details]
MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

Bug1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

To get the same behavior across all platforms for carets test, disable
'layout.word_select.eat_space_to_next_word'. In this way, we don't need
to worry about the spaces being selected on Windows, and those strip()
in individual tests can be eliminated.
Attachment #8670605 - Flags: review?(mtseng)
Comment on attachment 8670605 [details]
MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

https://reviewboard.mozilla.org/r/21415/#review19291
Attachment #8670605 - Flags: review?(mtseng) → review+
(Assignee)

Updated

2 years ago
Blocks: 1207934
(Assignee)

Updated

2 years ago
Blocks: 1200364
(Assignee)

Comment 3

2 years ago
Comment on attachment 8670605 [details]
MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

To get the same behavior across all platforms for carets test, disable
'layout.word_select.eat_space_to_next_word'. In this way, we don't need
to worry about the spaces being selected on Windows, and those strip()
in individual tests can be eliminated.
Attachment #8670605 - Attachment description: MozReview Request: Bug1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng → MozReview Request: Bug 1212186 - Disable 'layout.word_select.eat_space_to_next_word' in carets tests. r=mtseng

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/db9f90128b15
https://hg.mozilla.org/mozilla-central/rev/db9f90128b15
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.