[B2G][RIL] NITZ parcel is not correctly passed by reference-ril.

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: freesamael, Assigned: freesamael)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It seems the NITZ string is freed too early [1] and rild will get empty NITZ string on emulator.


[1] https://github.com/android/platform_hardware_ril/blob/b44dda3ea5bbbadb910479019f967b52cf9d69c7/reference-ril/reference-ril.c#L3113
Assignee: nobody → sawang
Blocks: 1209892
Created attachment 8670667 [details] [review]
Line should be freed after processed. r=echen
Comment on attachment 8670667 [details] [review]
Line should be freed after processed. r=echen

Hi Edgar,

Would you help to review the tiny patch?
Attachment #8670667 - Flags: review?(echen)

Comment 3

3 years ago
Comment on attachment 8670667 [details] [review]
Line should be freed after processed. r=echen

Nice catch!! Thank you.
Attachment #8670667 - Flags: review?(echen) → review+
Attachment #8670667 - Attachment description: line should be freed after processed → Line should be freed after processed. r=echen

Comment 4

3 years ago
b2g-kitkat:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/aa763fa9180a222547824ae6b6064e4851c15a86
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1217277
You need to log in before you can comment on or make changes to this bug.