Closed Bug 1212240 Opened 9 years ago Closed 9 years ago

[B2G][RIL] NITZ parcel is not correctly passed by reference-ril.

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: freesamael, Assigned: freesamael)

References

Details

Attachments

(1 file)

Line should be freed after processed. r=echen
60 bytes, text/x-github-pull-request
edgar
: review+
Details | Review
It seems the NITZ string is freed too early [1] and rild will get empty NITZ string on emulator. [1] https://github.com/android/platform_hardware_ril/blob/b44dda3ea5bbbadb910479019f967b52cf9d69c7/reference-ril/reference-ril.c#L3113
Assignee: nobody → sawang
Comment on attachment 8670667 [details] [review] Line should be freed after processed. r=echen Hi Edgar, Would you help to review the tiny patch?
Attachment #8670667 - Flags: review?(echen)
Comment on attachment 8670667 [details] [review] Line should be freed after processed. r=echen Nice catch!! Thank you.
Attachment #8670667 - Flags: review?(echen) → review+
Attachment #8670667 - Attachment description: line should be freed after processed → Line should be freed after processed. r=echen
b2g-kitkat: https://github.com/mozilla-b2g/platform_hardware_ril/commit/aa763fa9180a222547824ae6b6064e4851c15a86
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: