Closed Bug 1212246 Opened 9 years ago Closed 9 years ago

Remove task queue borrowing

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3250dfce9d15

It looks like no one is borrowing task queues and we can remove it now.
Assignee: nobody → jwwang
Blocks: 1148234
No longer blocks: 1148234
Bug 1212246. Part 1 - remove the aBorrowedTaskQueue parameter from the MediaDecoderReader constructor. r=jya.
Attachment #8671125 - Flags: review?(jyavenard)
Bug 1212246. Part 2 - remove mTaskQueueIsBorrowed and unnecessary checks for mTaskQueue is never null. r=jya.
Attachment #8671126 - Flags: review?(jyavenard)
Comment on attachment 8671125 [details]
MozReview Request: Bug 1212246. Part 1 - remove the aBorrowedTaskQueue parameter from the MediaDecoderReader constructor. r=jya.

https://reviewboard.mozilla.org/r/21537/#review19361

I never understood what that was for in the first place :)
Attachment #8671125 - Flags: review?(jyavenard) → review+
Attachment #8671126 - Flags: review?(jyavenard) → review+
Comment on attachment 8671126 [details]
MozReview Request: Bug 1212246. Part 2 - remove mTaskQueueIsBorrowed and unnecessary checks for mTaskQueue is never null. r=jya.

https://reviewboard.mozilla.org/r/21539/#review19363
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/3561a25a3db8
https://hg.mozilla.org/mozilla-central/rev/2e22f91760c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: