Closed Bug 1148234 Opened 5 years ago Closed 4 years ago

Give MSE subdecoders their own task queue and remove borrowing


(Core :: Audio/Video: Playback, defect)

Not set





(Reporter: bholley, Unassigned)




(1 file)

This would be a win on several levels:
* MediaSourceReader would interact with subdecoder readers the same way that the MDSM does, giving us more consistent access patterns to our readers.
* We could get rid of the weird scratch task queue that TrackBuffer uses to initialize subdecoders, and just use the one from the subdecoder.
* We could tighten up the fuzzy invariants surrounding what it means to "be on the decode task queue".

None of these are super important, but certainly nice to have - and I think this should actually be pretty easy to do with the recent promise work. I'm going to take a quick crack at it and see if I get lucky.
Sub-decoders are being removed shortly.
(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Sub-decoders are being removed shortly.

Oh? That would certainly change things here. What does the new architecture look like? Is there a bug tracking this?
Flags: needinfo?(jyavenard)
This is part of bug 1119208.
As discussed on IRC ; demuxed samples will now be stored in the TrackBuffers. The MediaSourceReader will only have use for a single decoder/reader per source buffer.
Flags: needinfo?(jyavenard)
Sounds good. I'll upload my WIP just in case and then forget about this.
Depends on: 1119208
Attached patch WIPSplinter Review
No longer blocks: MediaMonitor
Component: Audio/Video → Audio/Video: Playback
Depends on: 1212246
we don't have sub decoders with the new MSE.
Closed: 4 years ago
Resolution: --- → WONTFIX
No longer depends on: 1212246
You need to log in before you can comment on or make changes to this bug.