1212295 - Gecko does not notify user upon failure during recovery process for FOTA update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

Attachment: FOTA hacking

STR:
 0. Hack FOTA with the attached patch
 1. Generate FOTA
 2. Install FOTA: ANDROID_TOOLCHAIN=.../prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.8/bin/ ./tools/update-tools/test-update.py out/target/product/aries/fota-aries-update-fullimg.mar
 3. When prompted, apply update
 4. Let the device reboot into recovery
 5. During recovery there will be a failure because of the invalid Edify script, reboot the device from the recovery menu

Expected:
 After rebooting, B2G should notify the user that the FOTA failed

Actual:
 B2G reboots and we have no confirmation of the failure

Comment 1

[:gerard-majax]

Gecko update code has properly detected the failure at reboot:
> 10-07 14:12:59.105   355   355 I Gecko   : UpdatePrompt: Update error, state: failed, errorCode: 80
> 10-07 14:12:59.107   355   355 I Gecko   : UpdatePrompt: Warning: Couldn't send update event update-error: no content browser. Will send again when content becomes available.
> 10-07 14:12:59.108   355   355 I Gecko   : UpdatePrompt: Setting gecko.updateStatus: Install Failed

Comment 2

[:gerard-majax]

Gecko properly sends the event to SystemApp, but I suspect we do register too late the mozChromeEvent event handler in SystemUpdatable code ...

Comment 3

[:gerard-majax]

> 10-07 15:16:34.711   360   360 I Gecko   : XXX FIXME : Dispatch a mozChromeEvent: webapps-registry-ready
> 10-07 15:16:34.934   360   360 I Gecko   : XXX FIXME : Dispatch a mozChromeEvent: system-first-paint
> 10-07 15:16:36.725   360   360 I Gecko   : XXX FIXME : Dispatch a mozChromeEvent: update-error
> 10-07 15:16:36.726   360   360 I Gecko   : XXX FIXME : Dispatch a mozChromeEvent: volume-state-changed
> 10-07 15:16:38.215   360   360 D GeckoConsole: Content JS DEBUG: SystemApp: Update: mozChromeEvent: addEventListener 

We add the event listener two seconds after it was dispatched ...

Comment 4

[:gerard-majax]

Once we fix the race between Gecko and Gaia, then all we lack is a proper notification.

Comment 5

[:gerard-majax]

Attachment: Wait for SystemApp to be ready before sending update-error event r=...

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1212295 > mozilla-b2g:master

Comment 7

[:gerard-majax]

Attachment: Wait for SystemApp to be ready before sending update-error event

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8671256 [details] [review]
[gaia] lissyx:bug1212295 > mozilla-b2g:master

Yaaaay for killing long standing race conditions! \o/

Comment 9

[[:fabrice] Fabrice Desré]

Comment on attachment 8671312 [details] [diff] [review]
Wait for SystemApp to be ready before sending update-error event

Review of attachment 8671312 [details] [diff] [review]:
-----------------------------------------------------------------

:( for another event buffer. I really wish we fix bug 1161927 and bug 1172244

Comment 10

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/25d0524cf989fc13848d4d321db9ae18e10ec1a1

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/d093780814a4

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d093780814a4