Closed Bug 1212884 Opened 7 years ago Closed 7 years ago

SystemApp should show error notification upon failed system update

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:+)

RESOLVED FIXED
tracking-b2g +

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Keywords: late-l10n, Whiteboard: [systemsfe])

Attachments

(6 files)

We want to show a notification when we get an update-error for a sysem update error.

That notification will contain a couple of informations about the build we failed to install. It will instruct the user to report a bug. This can be done now or later.

Currently and after we fix the race condition in bug 1212295, we will only show a banner for 4 secs notifying of an error during the update process.
Jacqueline, that's a prototype for now, I suspect you will want to give your UX input on that :)
Flags: needinfo?(jsavory)
Whiteboard: [systemsfe]
Fred, I think this might impact your patch in bug 1161927 since SystemUpdatable error code path might move. Depending on how UX moves along on that, though, maybe you will prefer to land your patch and then we fix the UI ?

Can we just make sure the error code path with that new API is okay ?
Flags: needinfo?(gasolin)
I'd work on new API after 2.5, so feel free to land this if you want to ride on 2.5.

The new API should be compatible with current one, so it might not a big impact though.
Flags: needinfo?(gasolin)
Just a couple things :)
For the notification, the icon looks like it has an error, we can probably just keep using the update icon. I'll flag Eric to confirm. Also, the wording is a little repetitive, instead we could use:

First Line: 'System update error'
Second Line: 'Tap for more details'

For the error message, I wonder if we need to include the version and build ID if the user can report this as a bug where that information would be included? The wording could be changed to:

Title: System Update Error
Body: A problem occurred during the system update and the installation failed. Would you like to report this as a bug? 
Buttons: Later | Report

Also, where is the user able to report this later? Let me know what you think about the wording on this.
Flags: needinfo?(jsavory)
Flags: needinfo?(epang)
(In reply to Jacqueline Savory [:jsavory] UX from comment #10)
> Just a couple things :)
> For the notification, the icon looks like it has an error, we can probably
> just keep using the update icon. I'll flag Eric to confirm. Also, the
> wording is a little repetitive, instead we could use:

You just discovered my artistic skills: below sea level.

> 
> First Line: 'System update error'
> Second Line: 'Tap for more details'
> 
> For the error message, I wonder if we need to include the version and build
> ID if the user can report this as a bug where that information would be
> included? The wording could be changed to:
> 
> Title: System Update Error
> Body: A problem occurred during the system update and the installation
> failed. Would you like to report this as a bug? 
> Buttons: Later | Report

That is something that looks good. I do like having buildid/version but it's more cosmetic than anything.

> 
> Also, where is the user able to report this later? Let me know what you
> think about the wording on this.

Well the notification will not be closed, so he can still tap on it later. That notification will not survive a reboot though.
(In reply to Alexandre LISSY :gerard-majax from comment #11)
> (In reply to Jacqueline Savory [:jsavory] UX from comment #10)
> > Just a couple things :)
> > For the notification, the icon looks like it has an error, we can probably
> > just keep using the update icon. I'll flag Eric to confirm. Also, the
> > wording is a little repetitive, instead we could use:
> 
> You just discovered my artistic skills: below sea level.
> 
> > 
> > First Line: 'System update error'
> > Second Line: 'Tap for more details'
> > 
> > For the error message, I wonder if we need to include the version and build
> > ID if the user can report this as a bug where that information would be
> > included? The wording could be changed to:
> > 
> > Title: System Update Error
> > Body: A problem occurred during the system update and the installation
> > failed. Would you like to report this as a bug? 
> > Buttons: Later | Report
> 
> That is something that looks good. I do like having buildid/version but it's
> more cosmetic than anything.
> 
> > 
> > Also, where is the user able to report this later? Let me know what you
> > think about the wording on this.
> 
> Well the notification will not be closed, so he can still tap on it later.
> That notification will not survive a reboot though.

Hey Alexandre! Regarding the icon are you using this svg?
https://mozilla.box.com/s/m7nxhb09cd67rbf3ephk

Seems to have a bunch of artifacts in the transparent parts.  We should colour it the same as the other red icons in the notification tray.

Thanks!
Flags: needinfo?(epang)
Can one of you provide me a good icon for that notification? I'll change the strings as suggested by comment 10 and we should be able to land this.
Flags: needinfo?(jsavory)
Flags: needinfo?(epang)
Naoki, do we want to have this for 2.5 ? I would think so, now that we have FOTA working on Flame and soon on Z3c.
Flags: needinfo?(nhirata.bugzilla)
[Blocking Requested - why for this release]: UX issue.  I think we should have this for 2.5 release.  Pretty sure vendors will want this in so they can help troubleshoot issues; else have angry customers.
blocking-b2g: --- → 2.5?
Flags: needinfo?(nhirata.bugzilla)
Lets get it in if its ready but we are not blocking the release on it that late in the game.
blocking-b2g: 2.5? → ---
Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

This is a HUGE improvement.

Right now though, none of the string have been updated to based on jsavory's review, I'm still seeing the broken icon, and the notification will automatically close when I click on it which makes it impossible to report later. I left a comment in github about this.
Attachment #8678018 - Flags: review?(mhenretty)
(In reply to Michael Henretty [:mhenretty] from comment #18)
> Comment on attachment 8678018 [details] [review]
> [gaia] lissyx:bug1212884 > mozilla-b2g:master
> 
> This is a HUGE improvement.
> 
> Right now though, none of the string have been updated to based on jsavory's
> review, I'm still seeing the broken icon, and the notification will
> automatically close when I click on it which makes it impossible to report
> later. I left a comment in github about this.

Yeah, I have not updated the long descrition, but the notification name itself was. I used NotificationHelper in that new version for the localization but I have forgot it was closing the notification by default.

For the icon itself, I have asked :epang to provide me one :)
String and close on click should be good now. I'll just have to retest that on a live device to be extra sure.
Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

Should be all good now.
Attachment #8678018 - Flags: review?(mhenretty)
Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

Works well.

Left a nit on github about the button string. Other than that, r=me
Attachment #8678018 - Flags: review?(mhenretty) → review+
(In reply to Michael Henretty [:mhenretty] from comment #24)
> Comment on attachment 8678018 [details] [review]
> [gaia] lissyx:bug1212884 > mozilla-b2g:master
> 
> Works well.
> 
> Left a nit on github about the button string. Other than that, r=me

Fixed, waiting green try.
https://github.com/mozilla-b2g/gaia/commit/96b1c8185a6fb3aa824f6358314bda8cad39f58f
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jsavory)
Flags: needinfo?(epang)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.