1212884 - SystemApp should show error notification upon failed system update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

We want to show a notification when we get an update-error for a sysem update error.

That notification will contain a couple of informations about the build we failed to install. It will instruct the user to report a bug. This can be done now or later.

Currently and after we fix the race condition in bug 1212295, we will only show a banner for 4 secs notifying of an error during the update process.

Comment 1

[:gerard-majax]

Attachment: 2015-10-08-16-58-16.png

Comment 2

[:gerard-majax]

Attachment: 2015-10-08-16-58-27.png

Comment 3

[:gerard-majax]

Attachment: 2015-10-08-16-58-34.png

Comment 4

[:gerard-majax]

Jacqueline, that's a prototype for now, I suspect you will want to give your UX input on that :)

Comment 8

[:gerard-majax]

Fred, I think this might impact your patch in bug 1161927 since SystemUpdatable error code path might move. Depending on how UX moves along on that, though, maybe you will prefer to land your patch and then we fix the UI ?

Can we just make sure the error code path with that new API is okay ?

Comment 9

[[e-mail]]

I'd work on new API after 2.5, so feel free to land this if you want to ride on 2.5.

The new API should be compatible with current one, so it might not a big impact though.

Comment 10

[Jacqueline Savory [:jsavory] UX]

Just a couple things :)
For the notification, the icon looks like it has an error, we can probably just keep using the update icon. I'll flag Eric to confirm. Also, the wording is a little repetitive, instead we could use:

First Line: 'System update error'
Second Line: 'Tap for more details'

For the error message, I wonder if we need to include the version and build ID if the user can report this as a bug where that information would be included? The wording could be changed to:

Title: System Update Error
Body: A problem occurred during the system update and the installation failed. Would you like to report this as a bug? 
Buttons: Later | Report

Also, where is the user able to report this later? Let me know what you think about the wording on this.

Comment 11

[:gerard-majax]

(In reply to Jacqueline Savory [:jsavory] UX from comment #10)
> Just a couple things :)
> For the notification, the icon looks like it has an error, we can probably
> just keep using the update icon. I'll flag Eric to confirm. Also, the
> wording is a little repetitive, instead we could use:

You just discovered my artistic skills: below sea level.

> 
> First Line: 'System update error'
> Second Line: 'Tap for more details'
> 
> For the error message, I wonder if we need to include the version and build
> ID if the user can report this as a bug where that information would be
> included? The wording could be changed to:
> 
> Title: System Update Error
> Body: A problem occurred during the system update and the installation
> failed. Would you like to report this as a bug? 
> Buttons: Later | Report

That is something that looks good. I do like having buildid/version but it's more cosmetic than anything.

> 
> Also, where is the user able to report this later? Let me know what you
> think about the wording on this.

Well the notification will not be closed, so he can still tap on it later. That notification will not survive a reboot though.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1212884 > mozilla-b2g:master

Comment 13

[Eric Pang [:epang] UX]

(In reply to Alexandre LISSY :gerard-majax from comment #11)
> (In reply to Jacqueline Savory [:jsavory] UX from comment #10)
> > Just a couple things :)
> > For the notification, the icon looks like it has an error, we can probably
> > just keep using the update icon. I'll flag Eric to confirm. Also, the
> > wording is a little repetitive, instead we could use:
> 
> You just discovered my artistic skills: below sea level.
> 
> > 
> > First Line: 'System update error'
> > Second Line: 'Tap for more details'
> > 
> > For the error message, I wonder if we need to include the version and build
> > ID if the user can report this as a bug where that information would be
> > included? The wording could be changed to:
> > 
> > Title: System Update Error
> > Body: A problem occurred during the system update and the installation
> > failed. Would you like to report this as a bug? 
> > Buttons: Later | Report
> 
> That is something that looks good. I do like having buildid/version but it's
> more cosmetic than anything.
> 
> > 
> > Also, where is the user able to report this later? Let me know what you
> > think about the wording on this.
> 
> Well the notification will not be closed, so he can still tap on it later.
> That notification will not survive a reboot though.

Hey Alexandre! Regarding the icon are you using this svg?
https://mozilla.box.com/s/m7nxhb09cd67rbf3ephk

Seems to have a bunch of artifacts in the transparent parts.  We should colour it the same as the other red icons in the notification tray.

Thanks!

Comment 14

[:gerard-majax]

Can one of you provide me a good icon for that notification? I'll change the strings as suggested by comment 10 and we should be able to land this.

Comment 15

[:gerard-majax]

Naoki, do we want to have this for 2.5 ? I would think so, now that we have FOTA working on Flame and soon on Z3c.

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[Blocking Requested - why for this release]: UX issue.  I think we should have this for 2.5 release.  Pretty sure vendors will want this in so they can help troubleshoot issues; else have angry customers.

Comment 17

[Gregor Wagner [:gwagner]]

Lets get it in if its ready but we are not blocking the release on it that late in the game.

Comment 18

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

This is a HUGE improvement.

Right now though, none of the string have been updated to based on jsavory's review, I'm still seeing the broken icon, and the notification will automatically close when I click on it which makes it impossible to report later. I left a comment in github about this.

Comment 19

[:gerard-majax]

(In reply to Michael Henretty [:mhenretty] from comment #18)
> Comment on attachment 8678018 [details] [review]
> [gaia] lissyx:bug1212884 > mozilla-b2g:master
> 
> This is a HUGE improvement.
> 
> Right now though, none of the string have been updated to based on jsavory's
> review, I'm still seeing the broken icon, and the notification will
> automatically close when I click on it which makes it impossible to report
> later. I left a comment in github about this.

Yeah, I have not updated the long descrition, but the notification name itself was. I used NotificationHelper in that new version for the localization but I have forgot it was closing the notification by default.

For the icon itself, I have asked :epang to provide me one :)

Comment 20

[:gerard-majax]

String and close on click should be good now. I'll just have to retest that on a live device to be extra sure.

Comment 21

[:gerard-majax]

Attachment: Capture du 2015-10-29 14:58:46.png

Comment 22

[:gerard-majax]

Attachment: Capture du 2015-10-29 14:58:41.png

Comment 23

[:gerard-majax]

Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

Should be all good now.

Comment 24

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8678018 [details] [review]
[gaia] lissyx:bug1212884 > mozilla-b2g:master

Works well.

Left a nit on github about the button string. Other than that, r=me

Comment 25

[:gerard-majax]

(In reply to Michael Henretty [:mhenretty] from comment #24)
> Comment on attachment 8678018 [details] [review]
> [gaia] lissyx:bug1212884 > mozilla-b2g:master
> 
> Works well.
> 
> Left a nit on github about the button string. Other than that, r=me

Fixed, waiting green try.

Comment 26

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/96b1c8185a6fb3aa824f6358314bda8cad39f58f