1212297 - Chrome bookmarks migration doesn't drops errors on the floor, and should ignore Chrome's chrome:// URLs

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[:Gijs (he/him)]

The insertBookmarkItems thing just Cu.reportError's everything, and then the callback gets called with true.

The reason I was seeing errors was that the bookmarks in Chrome included:

chrome://bookmarks/

which we don't consider a valid chrome:// URLs.

I think we should just ignore all chrome:// URLs we get in the migration. I also think the error reporting should be better, not least for the sake of bug 731025 (which currently wouldn't flag up issues encountered in insertBookmarkItems, like the crazy URLs we saw for IE in bug 1194692).

I have a patch.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1212297 - improve error handling in Chrome bookmarks migration code, r?MattN

Bug 1212297 - improve error handling in Chrome bookmarks migration code, r?MattN

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8670749 [details]
MozReview Request: Bug 1212297 - improve error handling in Chrome bookmarks migration code, r?MattN

https://reviewboard.mozilla.org/r/21449/#review19325

::: browser/components/migration/ChromeProfileMigrator.js:62
(Diff revision 1)
> +        if (item.url.trim().startsWith("chrome:")) {
> +          // Skip invalid chrome URIs. Creating an actual URI always reports
> +          // messages to the console, so we avoid doing that.
> +          continue;
> +        }

I thought we already fixed handling chrome: URIs in another bug but maybe it never got fixed.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/eb5a0b994ea9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb5a0b994ea9

Comment 5

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 43.0.4 (20160105164030) under Mac OS X 10.10.5.
Verified fixed on Firefox 44 beta 8 (20160111185352) under Mac OS X 10.10.5, Windows 10 64-bit and Ubuntu 14.04 32-bit.