Closed
Bug 1212347
Opened 7 years ago
Closed 7 years ago
Disable GeckoView globally to disable geckoview_example
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
In bug 1201206, we determined gekcoview_example build failures shouldn't block landing bug 1201206 – let's disable it globally until we have a better build infrastructure (or it's killed).
Assignee | ||
Comment 1•7 years ago
|
||
Bug 1212347 - Disable GeckoView globally by default. r=nalexander
Attachment #8670802 -
Flags: review?(nalexander)
Assignee | ||
Comment 2•7 years ago
|
||
bug 1174757 was an attempt to do this before (with some caveats).
See Also: → 1174757
Comment 3•7 years ago
|
||
I think this is fine to land this patch to un-block bug 1201206, but let's make sure we have a bug on file to figure out how to fix the build failures (whether that means updating to gradle or just removing the example altogether).
Updated•7 years ago
|
Attachment #8670802 -
Flags: review?(nalexander) → review+
Comment 4•7 years ago
|
||
Comment on attachment 8670802 [details] MozReview Request: Bug 1212347 - Disable GeckoView globally by default. r=nalexander https://reviewboard.mozilla.org/r/21457/#review19389 If this works (try build?) it works for me. I bet it's not possible to override this locally: but we can sort out how to enable it locally some time in the future.
Assignee | ||
Comment 5•7 years ago
|
||
Here's bug 1201206 on top of this patch, which previously broke because of GeckoView: https://treeherder.mozilla.org/#/jobs?repo=try&revision=120bc0e0bca1
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1f1b7e749ffa703eb80ff74943a43894c3be6634 Bug 1212347 - Disable GeckoView globally by default. r=nalexander
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to :Margaret Leibovic from comment #3) > but let's make sure we have a bug on file to figure out how to fix the build failures > (whether that means updating to gradle or just removing the example altogether). Filed bug 1212973.
See Also: → 1212973
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bebc3593045d21d79739b846722c80498ae656b3 Bug 1212347 - Force clobber after disabling geckoview. r=me
Assignee | ||
Comment 9•7 years ago
|
||
This is after the fact because the push in bug 1201206 comment 36 passed try but failed on fx-team, perhaps due to a lack of clobber.
Comment 10•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f1b7e749ffa https://hg.mozilla.org/mozilla-central/rev/bebc3593045d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Assignee | ||
Updated•7 years ago
|
Summary: Disable geckoview_example globally → Disable GeckoView globally to disable geckoview_example
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•