Closed Bug 1212347 Opened 4 years ago Closed 4 years ago

Disable GeckoView globally to disable geckoview_example

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

In bug 1201206, we determined gekcoview_example build failures shouldn't block landing bug 1201206 – let's disable it globally until we have a better build infrastructure (or it's killed).
Bug 1212347 - Disable GeckoView globally by default. r=nalexander
Attachment #8670802 - Flags: review?(nalexander)
bug 1174757 was an attempt to do this before (with some caveats).
See Also: → 1174757
I think this is fine to land this patch to un-block bug 1201206, but let's make sure we have a bug on file to figure out how to fix the build failures (whether that means updating to gradle or just removing the example altogether).
Attachment #8670802 - Flags: review?(nalexander) → review+
Comment on attachment 8670802 [details]
MozReview Request: Bug 1212347 - Disable GeckoView globally by default. r=nalexander

https://reviewboard.mozilla.org/r/21457/#review19389

If this works (try build?) it works for me.  I bet it's not possible to override this locally: but we can sort out how to enable it locally some time in the future.
Here's bug 1201206 on top of this patch, which previously broke because of GeckoView:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=120bc0e0bca1
(In reply to :Margaret Leibovic from comment #3)
> but let's make sure we have a bug on file to figure out how to fix the build failures
> (whether that means updating to gradle or just removing the example altogether).

Filed bug 1212973.
See Also: → 1212973
This is after the fact because the push in bug 1201206 comment 36 passed try
but failed on fx-team, perhaps due to a lack of clobber.
https://hg.mozilla.org/mozilla-central/rev/1f1b7e749ffa
https://hg.mozilla.org/mozilla-central/rev/bebc3593045d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Summary: Disable geckoview_example globally → Disable GeckoView globally to disable geckoview_example
Duplicate of this bug: 1174757
You need to log in before you can comment on or make changes to this bug.