1212347 - Disable GeckoView globally to disable geckoview_example

Status: RESOLVED FIXED

Description

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

In bug 1201206, we determined gekcoview_example build failures shouldn't block landing bug 1201206 – let's disable it globally until we have a better build infrastructure (or it's killed).

Comment 1

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

Created attachment 8670802 [details]
MozReview Request: Bug 1212347 - Disable GeckoView globally by default. r=nalexander

Bug 1212347 - Disable GeckoView globally by default. r=nalexander

Comment 2

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

bug 1174757 was an attempt to do this before (with some caveats).

Comment 3

[:Margaret Leibovic]

I think this is fine to land this patch to un-block bug 1201206, but let's make sure we have a bug on file to figure out how to fix the build failures (whether that means updating to gradle or just removing the example altogether).

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8670802 [details]
MozReview Request: Bug 1212347 - Disable GeckoView globally by default. r=nalexander

https://reviewboard.mozilla.org/r/21457/#review19389

If this works (try build?) it works for me.  I bet it's not possible to override this locally: but we can sort out how to enable it locally some time in the future.

Comment 5

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

Here's bug 1201206 on top of this patch, which previously broke because of GeckoView:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=120bc0e0bca1

Comment 6

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

https://hg.mozilla.org/integration/fx-team/rev/1f1b7e749ffa703eb80ff74943a43894c3be6634
Bug 1212347 - Disable GeckoView globally by default. r=nalexander

Comment 7

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

(In reply to :Margaret Leibovic from comment #3)
> but let's make sure we have a bug on file to figure out how to fix the build failures
> (whether that means updating to gradle or just removing the example altogether).

Filed bug 1212973.

Comment 8

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

https://hg.mozilla.org/integration/fx-team/rev/bebc3593045d21d79739b846722c80498ae656b3
Bug 1212347 - Force clobber after disabling geckoview. r=me

Comment 9

[Michael Comella (:mcomella) [OOO through Nov. 30; needinfo or I won't see it]]

This is after the fact because the push in bug 1201206 comment 36 passed try
but failed on fx-team, perhaps due to a lack of clobber.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f1b7e749ffa
https://hg.mozilla.org/mozilla-central/rev/bebc3593045d