Closed
Bug 1213418
Opened 10 years ago
Closed 10 years ago
Use Fennec APKs in |mach artifact| based builds
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Right now, we product two AAR files (geckolibs and geckoview) when we're building GeckoView. (The former is a dependency of the latter.) The former geckolibs AAR files are consumed by |mach artifact| based builds (see Bug
Bug 1212347 stopped building GeckoView, in order to stop building geckoview_example. Unfortunately, that stops |mach artifact| builds from being updated.
This ticket tracks always packaging and uploading geckolibs, even when we're not building GeckoView.
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•10 years ago
|
||
I elected to go a different direction. Rather than turn on AAR files again, I've prepared patches to use fennec-*.apk files to extract the libraries. The AAR files are smaller -- almost half the size, ~20 Mb compared to ~40 Mb -- but they're special. Desktop builds expect to fetch a package artifact (.tar.gz, .dmg) and unpack it, so this approach aligns with what we will need for Bug 1207890 and Bug 1207888.
It's late on a Friday, so there are no reviewers around; this is Python code, and not part of the build; it's Android specific; and it's 100% busted -- I'm landing with r=me. Your good health!
| Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e8462d5d833b8041268f4d33391d8e9e26c9c2c9
Bug 1213418 - Part 1: Use mozregression to download in |mach artifact|. r=me
https://hg.mozilla.org/integration/fx-team/rev/0a2658b37fd01cda7b718320f5cfd7dc23d5c521
Bug 1213418 - Part 2: Use Fennec APKs in |mach artifact|; use mozversion to extract build IDs. r=me
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e8462d5d833b
https://hg.mozilla.org/mozilla-central/rev/0a2658b37fd0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment 4•10 years ago
|
||
Does this mean you can no longer include GeckoView into gradle projects?
https://github.com/ncalexan/geckobrowser-gradle
| Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Does this mean you can no longer include GeckoView into gradle projects?
> https://github.com/ncalexan/geckobrowser-gradle
Yes, we're not currently building and uploading AARs. We can patch this back in sometime soon, and I intend to work on a more comprehensive solution this quarter.
Updated•6 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 44 → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•