121241 - Misplaced insertion line for outliner DND

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P3)

Description

[Pierre Chanial]

Linux build 2002 01 21 21

During a drag and drop in the bookmark outliner, the insertion line appears at
two positions between items:
- just below the first item
- just above the second item (item is shifted, as reported)
Only one position should be needed for the insertion line.

Comment 1

[NilsE]

Confirming on CVS 2002-01-22, 0700 UTC, Linux.

In addition, if I file the same bookmark several times, using either inserting
position, some magically disappear. But they're in bookmarks.html, but only
until shutdown. After restart some of these invisible dupes are being
eliminated. But that's problably a different bug.

Comment 2

[[not reading bugmail]]

*** This bug has been marked as a duplicate of 114606 ***

Comment 3

[[not reading bugmail]]

Nilse,

the first comment/bug summary is covered by my change to the dupe, see bug
114606 comment #25 for more.  I think filing the same bookmark, it should be not
added to the same folder more than once.. and hence should be gone from the
bookmarks.html.. the only case is if they are in different folders.  This is
necessary for the merge bookmarks functionality in a really old bug.

Comment 4

[[not reading bugmail]]

changing bug to dependency, Pierre has a very good point.

Comment 5

[Jan Varga [:janv]]

I just noticed that ns4.x supports both drop orientations too.
So I wonder if this is actually bug.

Comment 6

[Blake Ross]

Jan, you're working on this, aren't you? That's the impression I got, sorry if not.

Comment 7

[Jan Varga [:janv]]

ok, I'll try to figure out something.

Comment 8

[Jan Varga [:janv]]

Yeah current behaviour sucks!
Here comes a new patch, hope you will like it

Comment 9

[Jan Varga [:janv]]

Attachment: proposed fix

this took me so much time, sigh
it should look better now.

Comment 10

[Jan Varga [:janv]]

need some testing on mac, any volunteers ?

Comment 11

[Jan Varga [:janv]]

zach, could you test on Mac ?

Comment 12

[Jan Varga [:janv]]

Attachment: new patch, contains also a fix for scrollbar not updating

Comment 13

[Jan Varga [:janv]]

Attachment: added comments

Comment 14

[Jan Varga [:janv]]

tested on linux and winnt, looks good so far

Comment 15

[David Hyatt]

sr=hyatt

Comment 16

[Mike Pinkerton (not reading bugmail)]

two questions:

- you create an atom for dragSession but i don't see it used anywhere besides
putting it into the list. shouldn't it show up in the css somewhere?

- GetFinalImageSize() to get the dimensions of the twisty will be wrong when the
skin is using a theme impl. You have to query the theme impl to get the
width/height of the twisty.

Comment 17

[Jan Varga [:janv]]

I added dragSession atom for future use.

I'll try to address twisty size in 123605.

Comment 18

[Mike Pinkerton (not reading bugmail)]

i tried on mac and there are still problems.

for example, when the very first item in my bookmarks list is a folder, moving
the mouse into it causes the folder to select, then clear. there is no drop
feedback until you move the mouse out of the container. it doesn't matter if the
folder is open or closed.

Of greater importance, though, is if I hold the mouse in the lower portion of
the open container (the bottom 25% or so), the drop feedback shows that it will
go at the same level as the container, but between it an its children (which is
very wrong), but then dropping it puts it _above_ the container. 

i also think that the "move between" feedback is indented too much. for an open
container, it's at the same level as its children which makes me think the drop
will make it a child. It should be moved over more to the left, between the
icons. it should probably also be wider horizontally to be more visible.

Comment 19

[Jan Varga [:janv]]

ok, trying to fix it

Comment 20

[Jan Varga [:janv]]

Attachment: better fix

This patch should address all comments pointed by pinkerton.
All except incorrent dropping above a container.
That and other issues should be covered in bug 114606.

Comment 21

[Jan Varga [:janv]]

Zach said, it buids and works fine on Mac.
Pink, could you stamp it with an r= ?

Comment 22

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 68170 [details] [diff] [review]
better fix

r=pink. so much better ;)

Comment 23

[Jan Varga [:janv]]

fixed

Comment 24

[Pierre Chanial]

Great!
Marking verified on linux build 2002 02 08 21

Comment 25

[[not reading bugmail]]

Jan,

this will help you fix the other stuff:

if you are moving a *highlighted* bookmark there is still two insertion bars..
they are extremely close together.  and will still get the same effect as in
114606.  it doesn't do the shifting.. that is fixed.  I see it is below the
highlighted bookmark, and one is above the highlighted line.  The one above the
highlighted line will insert above the unhighlighted bookmark above the
highlighted one.  

Comment 26

[Jan Varga [:janv]]

Dennis, that's bookmarks issue, not outliner related in general.

Comment 27

[[not reading bugmail]]

Thanks for that clarification, as you could probably tell, I didn't understand
the  difference between the outliner and its relationship with bookmarks code. 
I'm trying though.

Dennis