1212461 - Changes to stage/prod environment variables to make local.py redundant

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P2)

Description

[Ed Morley [:emorley]]

We're wanting to stop using local.py on stage/prod - and instead use only environment variables, for a variety of reasons. 

Most of the settings in stage/prod's local.py are also already in the environment - there are just a few remaining items, which will be resolved here.

fubar, at some point (no immediate rush) can you make the following changes...


Stage {treeherder-env.sh.erb, profile.sh.erb}:

* Add a new variable 'DATA_CYCLE_DAYS' which has a value of 45.
* Add 'SITE_URL', 'TREEHERDER_REQUEST_PROTOCOL' and 'TREEHERDER_REQUEST_HOST' - which have the same values as currently set in stage's 'settings_local.py.erb'.
* Remove the 'TREEHERDER_DEBUG' lines. (Since it's actually setting debug to on, and is only countered by luck, by the fact that local.py takes precedence).


Production {treeherder-env.sh.erb, profile.sh.erb}:

* Add 'SITE_URL', 'TREEHERDER_REQUEST_PROTOCOL' and 'TREEHERDER_REQUEST_HOST' - which have the same values as currently set in prod's 'settings_local.py.erb'.
* Remove the 'TREEHERDER_DEBUG' lines.


We'll file a bug later when we have fully moved off of local.py, requesting its removal.

Thanks :-)

Comment 1

[Kendall Libby [:fubar] (he/him)]

Done in r108874. puppet will apply it in the next ~hour.

Comment 2

[Ed Morley [:emorley]]

Looks good - thank you :-)