1212822 - Stop using local.py other than for development

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

I'm splitting this out of bug 1197186.

Let's stick the local.py import under a `if DEBUG:` or `if VAGRANT:` since we shouldn't be using it for anything other than local development.

Comment 1

[Ed Morley [:emorley]]

Attachment: Only load local.py in the Vagrant environment

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3ac35b24887f3a22bf80c7b73747434d51d2920c
Bug 1212822 - Allow setting PULSE_EXCHANGE_NAMESPACE via the environment

So it can still be set on stage/prod, where we want to stop using
local.py. (It's already set in the environment there, we just need to
start using it.)

https://github.com/mozilla/treeherder/commit/19d3570a1ef5debd97dc42354e7cbed07b267952
Bug 1212822 - Check the environment for SITE_URL not TREEHERDER_SITE_URL

On stage/prod the environment variable set is SITE_URL rather than
TREEHERDER_SITE_URL (this doesn't affect anything at the moment, since
local.py is being used, but we want to remove it). Instead of changing
the puppet configs its probably easier to just adjust what variable we
look at, particularly since the non-prefixed form is more concise and
matches what it actually controls.

I've added SITE_URL to Heroku in preparation.

https://github.com/mozilla/treeherder/commit/d9bd20efd18e7a39e55884c377e196466b231772
Bug 1212822 - Only load local.py in the Vagrant environment

Ideally we'd remove local.py entirely, in favour of environment
variables. However at least for now, it's still needed for setting the
logging preferences/enabling debugging apps for the Vagrant environment.
As such, it's being kept but disabled everywhere other than for local
development.

The stage/prod local.py files have been vetted, and (a) the contents
confirmed to match that in the environment, and (b) all affected
settings in base.py checked to ensure they read the correct environment
variable. Heroku doesn't have a local.py. As such, this should be a
no-op other than locally, where a Vagrant provision will be required.