Need to port gtkmozembed to gtk2.
Just FYI, I do have a building copy as well in a local tree that is a lot cleaner than that patch. I just need finish it up. It will happen in the next week to week and a half.
How is the port doing?
Chris, any chance to get your patches in for mozilla 1.2 ? That code, along with bug 144212 patch, appear to work already very well. No crashes neither critical issues.
Chris: I recall that you have patch for it, any plan to upload that here? thanks. -Jay
I should have something to upload by the end of the day. I'm bringing my gtk2 tree back into shape as we speak.
Still working on this.
Created attachment 103733 [details] [diff] [review] patch This patch should work and compile with both gtk2 and gtk 1.2, shouldn't cause any regressions to the 1.2 code. I can't find any obvious problems with the embedding widget in either port with this patch.
Looking at the patch I'd guess the crash reported in bug 144212 is still happening. I cant test it before Friday though :( To have a fully functional gtkmozembed we need also to address 162507. (Yeah I know this is only slightly related to this bug). Thanks to be working on this !
I haven't tested the new patch, but bug #156093 probably still happens with this patch.
Created attachment 103966 [details] [diff] [review] Fix build errors with --disable-accessibility This patch should fix build errors that occur because nsAccessibilityInterface.cpp is being built even if --disable-accessibility configuration option is used.
With the current patch, build fails on TestGtkEmbed because it's being linked against gtksuperwin, which doesn't exist for gtk2 build; proper ifdefs are missing from the Makefile.in.
Created attachment 104007 [details] [diff] [review] Fix TestGtkEmbed build errors This patch sets the LIBS depending on whether gtk1 or gtk2 is used. Works at least with gtk2, but I don't see why it wouldn't work with gtk1 as well.
Comment on attachment 103966 [details] [diff] [review] Fix build errors with --disable-accessibility please open a new bug and put this patch in it since it's not strictly embedding-related
The mozilla-gtkmozembed.pc that's generated for gtk2 build also falsely includes the -lgtksuperwin option. This makes building eg. galeon fail.
What is happening with this bug? This is by far the most important bug when it comes to gtk2.
I'll start working on this again on Thursday when I return from being out of town at offsite meetings. Relax.
Created attachment 106446 [details] [diff] [review] patch updated patch
The latest patch here compiles with gtk2 and gtk1.2 and doesn't seem to cause any regressions to the 1.2 code. It's also got a couple of other patches rolled up into it.
Comment on attachment 106446 [details] [diff] [review] patch I'm going to assume this is sr=bryner as well.
Checked in. Thanks!