1212864 - [New-Homescreen] Remove pinch gesture

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

Currently column layout uses a pinch gesture to change, but the performance is sub-optimal and it doesn't look like they'll be time to rectify it. Instead, we should remove it and rely on the homescreen settings menu.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1212864-new-homescreen-remove-pinch > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8671412 [details] [review]
[gaia] Cwiiis:bug1212864-new-homescreen-remove-pinch > mozilla-b2g:master

This patch introduces a global homescreen settings datastore, owned by Settings. New homescreen uses this to read the columns setting, which is now reinstated back in the main homescreens panel. When verticalhome is the current homescreen, the old datastore is used - I had a go at a few ideas for migration paths, but everything ended up being overkill vs. this reasonably simple solution (and we can remove some of this code after we finish migration).

r?gasolin for Settings changes, r?gmarty for homescreen changes.

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8671412 [details] [review]
[gaia] Cwiiis:bug1212864-new-homescreen-remove-pinch > mozilla-b2g:master

The set of changes on the new homescreen look good to me, with a comment left on Github. Would be nice to have a couple of unit test too.

Comment 4

[[e-mail]]

It works fine on device. 

The only issue is about UX design, ni @tina the Icon layout is only shared between default two homescreens, it may not suit for other homescreens and make an impression that other homescreens as the second-class citizens. Does the icon layout field suit for present in the main homescreens panel?

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8671412 [details] [review]
[gaia] Cwiiis:bug1212864-new-homescreen-remove-pinch > mozilla-b2g:master

Whoops, it was this bug that I meant to re-flag for review, not bug 1212905. I've refactored all the settings out into a separate, unit-tested file. I also changed the saving logic slightly to be more reliable/less expensive.

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8671412 [details] [review]
[gaia] Cwiiis:bug1212864-new-homescreen-remove-pinch > mozilla-b2g:master

LGTM!

Comment 7

[Tina Hsieh[:Tina_Hsieh] UX]

@Fred No, we agreed that it shouldn't be in the main Home Screens panel.

We suggested that every single customized home screen setting should contain a Icon Layout setting (just like the "Default Home Screen" setting in v2.5) if the home screen layout can be selected the number of the columns.

Comment 8

[Chris Lord [:cwiiis]]

(In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #7)
> @Fred No, we agreed that it shouldn't be in the main Home Screens panel.
> 
> We suggested that every single customized home screen setting should contain
> a Icon Layout setting (just like the "Default Home Screen" setting in v2.5)
> if the home screen layout can be selected the number of the columns.

So every details page of a homescreen should have its own settings there? That seems like something a user would never discover (the page itself is pretty undiscoverable as it is, it's 3 pages deep from the main settings and under an option that says 'Change Home Screen', implying nothing about settings)...

Ideally, what we want is a method for homescreens to be able to put their settings in the main page, but we don't have time to implement this for 2.5. We currently have no way of knowing whether a homescreen should have column settings or not (except to hard-code a list of known homescreens with such settings, but that has the same problems you're trying to avoid).

n?robmac because I implemented what we discussed in a meeting about homescreen and this seems to go against what we discussed there...

Comment 9

[Chris Lord [:cwiiis]]

Not checking this in is making it super-awkward to work on homescreen, and holding up testers from getting updates - I'm going to check this in and we can address possible UX issues in follow-up. Apologies if this causes anyone any trouble, feel free to blame anything on me :)

Comment 10

[[e-mail]]

anyway we do follow the current UX spec and all function works, let's check this in and go forward

Comment 11

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/3590e6414dafb17dabe438322543561d8a4a141e

Comment 12

[Chris Lord [:cwiiis]]

Well, no objections have come up, I guess this is fine.