Closed Bug 1212887 Opened 4 years ago Closed 4 years ago

10.10.5 tests run on try when 10.10 is explicitly specified

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kmoir, Assigned: kmoir)

References

Details

Attachments

(2 files, 1 obsolete file)

10.10.5 tests should not run by on try unless 10.10.5 is specified but this seems to be happening. This is not good because they are not greened up yet see bug 1210395

https://hg.mozilla.org/try/rev/33bc0551337f
Depends on: 1210395
	Callek_cloud	kmoir: #2 (10.10 running 10.10.5) is dicey unless we rename 10.10 to 10.10.0 aiui: https://dxr.mozilla.org/build-central/source/buildbotcustom/try_parser.py#191
	Callek_cloud	since that code means 10.10 does indeed match 10.10.5, but is setup in a way that makes this "harder" to fix
Attached patch bug1212887.patch (obsolete) — Splinter Review
Alin suggested using exclusions to get around this temporarily which works

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96312aa64044

not sure if this patch will do the trick
Attached patch bug1212887.patchSplinter Review
Attachment #8671996 - Attachment is obsolete: true
Attachment #8672000 - Flags: review?(bugspam.Callek)
Comment on attachment 8672000 [details] [diff] [review]
bug1212887.patch

Review of attachment 8672000 [details] [diff] [review]:
-----------------------------------------------------------------

slightly concerned that some humans and other cli tools won't let this change solve this well. But I'm happy giving this a shot.
Attachment #8672000 - Flags: review?(bugspam.Callek) → review+
Thanks Alin for this idea, it worked.

I'll leave this open because we'll want to revert it when the 10.10.5 tests are green
ok, 10.10.5 is live- shall we revert things?
patch to revert
Attachment #8689520 - Flags: checked-in+
new version of trychooser deployed
Assignee: nobody → kmoir
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.