Closed Bug 1212956 Opened 10 years ago Closed 10 years ago

Scrolling blanking results page

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox44 --- affected

People

(Reporter: Gijs, Assigned: erik)

References

Details

STR: 1. Open: https://dxr.mozilla.org/mozilla-central/search?q=windowwatcher&=mozilla-central&redirect=true 2. scroll down Where did my results go? For more fun: STR: 1. Open: https://dxr.mozilla.org/mozilla-central/search?q=windowwatcher&=mozilla-central&redirect=true 2. add path:idl to the search and hit enter in the box Where did my results go? Oh, it helpfully decided to auto-tick "case sensitive" which I didn't ask for, and now it gets 0 results because it's trying to be case-sensitive. This is destroying my productivity more and more every day. I can't trust the tool that's supposed to just be "grep" on our entire codebase (but slightly more clever).
Flags: needinfo?(erik)
Hmm, I can't reproduce your first scenario. Does a reload do anything? (It shouldn't, as we now have proper cachebusting for JS and such.) As for the second, the case-sensitive checkbox is a lost cause, and we're ripping it out; see bug 1184747. The patch looks pretty good; I'll try to land it soon.
Flags: needinfo?(erik)
(In reply to Erik Rose [:erik][:erikrose] from comment #1) > Hmm, I can't reproduce your first scenario. Does a reload do anything? (It > shouldn't, as we now have proper cachebusting for JS and such.) It works now, but when I reported this it wasn't just me for whom it was broken, see http://logs.glob.uno/?c=mozilla%23developers#c1309371 and responses from bholley, froydnj and bz.
I was going to pop in a suggest maybe one of the web heads was being weird, when #1 happened to me... scrolled down and everything blinked and disappeared. I can make it happen reliably atm.
Aha! I got it to happen for me in Safari. Now I can chase it down. Apologies, Gijs, and thanks, Kendall!
Looks like it has to do with the Case-sensitive checkbox (drat that thing). When I check it in Firefox, the bad behavior shows up.
Summary: DXR is randomly breaking → Scrolling blanking results page
Assignee: nobody → erik
Reducing a bit, this happens when... 1. The query string does not match case-sensitively. 2. The query string has no `case` param. 3. The case-sensitivity flag saved in localstorage is on. I'm not sure where URLs without a case param come from, but we shouldn't behave weirdly regardless.
Commit pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/e57c862b36c96a9c5f049f6db939c7a31ef4431c Keep results from blanking on scroll. Fixes bug #1212956. Fixes bug #1072546. The query run by infinite scroll is built from, among other things, the state of the Case-sensitive checkbox. Make sure that's synced up with the case param of the querystring on load.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/6c1aca647e1bec9d42c096136b433d542a9a2311 Fix scroll blanking issues. Fix bug 1212956. This is sort of a wallpaper, but even so. We shouldn't clear the result page if we're appending.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.