1213102 - Provide repack fix for jetpack add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Andy McKay]

Add-ons built with jpm will break because of bug 1202902. We need the fix as per this commit:

https://github.com/mozilla-jetpack/jpm-core/pull/1/files

We should also publicise this change so add-ons not on AMO can be fixed. According to a pretty crude search on MXR: 

http://mzl.la/1jdEQfv

there's around 879 add-ons affected by this.

Ideally we can repack all the affected add-ons on AMO  as part of the compatibility bump so that add-on authors don't have to do anything.

Comment 1

[Andy McKay]

I tried the fix in jpm-core on an add-on and noted that the add-on then worked from Nightly through to stable, meaning that we can probably apply this repack at any time (for this line of code at least).

Comment 2

[Dave Townsend [:mossop]]

Remember that you'll need to bump the add-on version if you want users to update to the fixed versions.

Comment 3

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to Andy McKay [:andym] from comment #0)
> Ideally we can repack all the affected add-ons on AMO  as part of the
> compatibility bump so that add-on authors don't have to do anything.

All add-ons or just jpm ones?

Comment 4

[Dave Townsend [:mossop]]

(In reply to Luís Miguel [:quicksaver] from comment #3)
> (In reply to Andy McKay [:andym] from comment #0)
> > Ideally we can repack all the affected add-ons on AMO  as part of the
> > compatibility bump so that add-on authors don't have to do anything.
> 
> All add-ons or just jpm ones?

jpm ones are the only ones that can be automatically fixed. cfx built add-ons seem fine, other add-ons are the wild-west.

Comment 5

[Dave Townsend [:mossop]]

I think we can fix this in Firefox without needing to repack these add-ons, see bug 1217070

Comment 6

[Andy McKay]

The Firefox fix  in bug 1217070 got a lot, leaving us with a small number to repack, based on 1213160. @magopian, let's file bugs and get this moving.

Comment 7

[labingdaga]

https://addons.mozilla.org/en-US/firefox/addon/tiddlyfox/

is a plug-in that needs to be repacked for FireFox 44

Comment 8

[Luís Miguel [:quicksaver] (not reading bugmail)]

I was told that only jpm add-ons would be repackaged, yet my add-ons were repackaged and their versions were bumped as well, and they weren't even busted as I had fixed them myself already as soon as the changes hit nightly! The single change that the auto-repackage did was a const to a var that was already working as expected, which means the process pushed for a new update of all my add-ons for absolutely no reason.

What's done is done I guess, but this did catch me off guard...

Comment 9

[Kris Maglione [:kmag]]

The plan was never to only repack JPM add-ons. See the thread where this was proposed:

https://mail.mozilla.org/pipermail/dev-addons/2015-October/000083.html

The list of add-ons to repack was generated a few weeks before the repackaging script was ready, so many of them were already fixed by the time that we ran it. The rewriting script is extremely cautious, though, so I decided to stick with the original list rather than run a new scan. Ideally, we probably should have skipped versions which were uploaded after the change was introduced in nightlies, and explicitly supported Firefox 44, but it's too late at this point.

Comment 10

[Kris Maglione [:kmag]]

I guess this is fixed, but I don't know the Github issue number it wound up migrating too.

There might need to be a follow-up bug, though, since from what I understand there were a lot of cases where we only repacked the latest beta version of an add-on rather than the latest release.