1213226 - [RTL][First Time Experience]On FTE "Select a network" page, the refresh icon on title is not left-aligned.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: Aries2.5&Flame2.5_FTE Select network page.png

[1.Description]:
[RTL][Aries KK v2.5][Flame KK v2.5][First Time Experience]On FTE "Select a network" page, the refresh icon on title is not left-aligned.
See attachment: Aries2.5&Flame2.5_FTE Select network page.png

[2.Testing Steps]: 
1. Launch FTE and set your phone language to Arabic in FTE in Language page 
2. Tap Next to enter the "Select a network" page. 
3. Observe the page. 

[3.Expected Result]: 
3.The refresh icon on title should be left-aligned, the text should read right to left. 

[4.Actual Result]: 
3. The refresh icon on title is not left-aligned.

[5.Reproduction build]: 
Device: Aries KK v2.5 (Affected)
Build ID               20151008233852
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23b7f289df923c01e692299fcd4be7029de8b155
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151008.225742
Firmware Date          Thu Oct  8 22:57:51 UTC 2015
Bootloader             s1

Device: Flame KK v2.5 (Affected)
Build ID               20151008150210
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e5f1bc63ad52d0eb86f7fb838226ca6036774660
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151008.182756
Firmware Date          Thu Oct  8 18:28:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15453

Comment 1

[Sam Foster [:sfoster] (he/him)]

This is DOM managed by the FTU app, which has a single <gaia-header> which is updated for each panel. In apps/ftu/index.html I see the ignore-dir attribute on the <gaia-header> there. As I understand it, this is an opt-in mechanism that should be removed once the app has had its CSS refactored? FWIW I tried setting ignoreDir to false in the inspector/console but it had no effect.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1213226-ftu_rtl_header > mozilla-b2g:master

Comment 3

[Augustin Trancart [:autra]]

Comment on attachment 8679662 [details] [review]
[gaia] Phoxygen:bug1213226-ftu_rtl_header > mozilla-b2g:master

Hey Sam, please R?

FWIW, just setting ignore-dir to false is not enough, because gaia-header merely check the presence of the attribute to decide whether to ignore direction or not. 

Doing it at runtime with the webIDE gives mixed results: the button change side, but one margin stays at the wrong side. It is not intended to be a runtime switchable option, actually.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8679662 [details] [review]
[gaia] Phoxygen:bug1213226-ftu_rtl_header > mozilla-b2g:master

Tested on device with Arabic and english. Looks great, thanks. I think we can be confident the sync-test/unit/sync-engine/syncengine_test.js failure is unrelated :)

Comment 5

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/39aef3288f3211e5bd71da879f6ac75d34fcafb1

Comment 6

[Shine(Leave from Mozilla)]

Attachment: Verify_flameKKv2.5.png

This problem is verified as pass on latest build of Flame KK 2.5&2.6, Aries KK 2.5&2.6 by the STR in comment 0. In RTL mode, the refresh icon on title is left-aligned and the text read right to left. 
Reproduce rate: 0/5
See attachment: Verify_flameKKv2.5.png

Device: Flame KK v2.5 512MB (Pass) 
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Pass) 
Build ID               20151109233837
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/772f6c235fc48d91efd6346f5b3d8b216eb2dcb1
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.225902
Firmware Date          Mon Nov  9 22:59:11 UTC 2015
Bootloader             s1

Device: Aries KK v2.6(Master)(Pass) 
Build ID               20151109151826
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.143842
Firmware Date          Mon Nov  9 14:38:50 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 512MB(Master)(Pass) 
Build ID               20151109150204
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.182508
Firmware Date          Mon Nov  9 18:25:22 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0