1207259 - (Gaia RTL 2.5) CSS refactoring: [Building Blocks] First Time Use

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[gabriel]

Improve the RTL support of the FTU app by refactoring the stylesheets for these building blocks:

 • buttons
 • confirm
 • input_areas
 • lists
 • progress_activity
 • status

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bb-first-time-use > mozilla-b2g:master

Comment 2

[gabriel]

Attachment: CSS refactoring for RTL support of building blocks

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8664375 [details] [review]
CSS refactoring for RTL support of building blocks

LGTM :) thanks

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Seems ready to go in.
Gabriel could you please squash your commits into one that matches the bug title? Thanks!

Comment 5

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8664374 [details] [review]
[gaia] Phoxygen:bb-first-time-use > mozilla-b2g:master

Marking as obsolete so Autolander doesn't go nuts when a checkin-needed flag is requested.

Comment 6

[gabriel]

As pierre-eric said to you on https://bugzilla.mozilla.org/show_bug.cgi?id=1207202, the last commit is supposed to be reverted as soon as bug #1207131 is resolved, is it okay if I keep this one and squash the others?

Comment 7

[Ahmed Nefzaoui [:Nefzaoui]]

Please squash everything (as Pierre Eric tells me there will be another PR to revert the linter changes after bug 1207131 lands) and add checkin-needed flag to the keywords (or let me know and I'll add that).

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Sorry I mean a PR to revert the xfail* changes.

Comment 9

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/da9d84c