Closed Bug 1213301 Opened 9 years ago Closed 9 years ago

Convert imagecompare tests for music-nga app

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: njpark, Assigned: njpark)

References

Details

Attachments

(1 file, 3 obsolete files)

[gaia] npark-mozilla:really_clean_1213301 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #1208553 +++ The music-NGA app which is scheduled to replace the current Music app is internally in many ways different from the Music app. Need a converted Music-NGA app methods to run imagecompare test cases on it.
Assignee: nobody → npark
Attachment #8672020 - Attachment is obsolete: true
Comment on attachment 8672152 [details] [review] [gaia] npark-mozilla:clean_1213301 > mozilla-b2g:master >https://github.com/mozilla-b2g/gaia/pull/32373
Attachment #8672152 - Attachment is obsolete: true
Attachment #8672107 - Attachment is obsolete: true
Attachment #8672172 - Flags: review?(martijn.martijn)
Comment on attachment 8672172 [details] [review] [gaia] npark-mozilla:really_clean_1213301 > mozilla-b2g:master I think it looks good, made a comment in the pull request about an unused method and something about PageRegion. I haven't tested this out myself, if you want me to test this out, then please re-ask review.
Attachment #8672172 - Flags: review?(martijn.martijn) → review+
I made changes per your comment, and made sure all music tests were passing. Merged: https://github.com/mozilla-b2g/gaia/commit/c350ccbd62174713ade160287ca347191e30f9d9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: