1213323 - Cancel button is sized wrong in action menu after long pressing a Call Log entry in Dialer

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Martin Shuman [:Marty]]

Attachment: Call-Log-Cancel-Screenshot.png

Description:
If the user has at least one call in their Call Log, and they long press that entry, the cancel button will be much shorter than it any other, similar cancel buttons found elsewhere.  This also results in the 'Cancel' text being very small.

Note: This issue does not appear to be affecting any other Cancel buttons on the device.

Repro Steps:
1) Update a Aries to 20151009104251
2) Make or receive one phone call with the DUT
3) Open the Dialer app and navigate to Call Log
4) Long press the previous call to open the action menu.

Actual:
The Cancel button in call log is extremely short, and the text is very small.

Expected:
The Cancel button is a proper size, consistent with other cancel buttons, and the text is size appropriately.

Environmental Variables:
Device: Aries 2.5
Build ID: 20151009104251
Gaia: 1609aecaba381c14eff95d5084e59280f53b7d8b
Gecko: d01dd42e654b8735d86f9e7c723cc869a3b56798
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 5/5
See attached: Screenshot, Logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
The Cancel button in call log is extremely short, and the text is very small.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151009030234
Gaia: 1609aecaba381c14eff95d5084e59280f53b7d8b
Gecko: d01dd42e654b8735d86f9e7c723cc869a3b56798
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

***************************************

This issue does NOT occur on the latest Flame 2.2 build.
The Cancel button is a proper size, consistent with other cancel buttons, and the text is size appropriately.

Environmental Variables:
Device: Flame 2.2
BuildID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This looks really bad so nominating this to block.

Comment 3

[Max Murrell [MMurrell]]

This issue is caused by Bug 1213135
Central Regression Window:

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20151010072351
Gaia: a9399f148859dc9dce73c4f2a2fd7653388aa9bc
Gecko: 7931c67161d4bab385134c34fb1f819864c3daab
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20151010153347
Gaia: d6cc7ef0b409af4b83d0d1ccc7c1f4ddba28284e
Gecko: 828d109669c6217e14df92970f1c6cbe3635ce13
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D

Last Working gaia / First Broken gecko - Issue does not occur 
Gaia: a9399f148859dc9dce73c4f2a2fd7653388aa9bc
Gecko: 828d109669c6217e14df92970f1c6cbe3635ce13

First Broken gaia / Last Working gecko - Issue does occur
Gaia: d6cc7ef0b409af4b83d0d1ccc7c1f4ddba28284e
Gecko: 7931c67161d4bab385134c34fb1f819864c3daab

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/a9399f148859dc9dce73c4f2a2fd7653388aa9bc...d6cc7ef0b409af4b83d0d1ccc7c1f4ddba28284e

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1213323_fix_underspecified_button_declaration > mozilla-b2g:master

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8672873 [details] [review]
[gaia] KevinGrandon:bug_1213323_fix_underspecified_button_declaration > mozilla-b2g:master

It turns out most apps that use the menu include buttons.css from shared which defaults the button state in many cases. I want to take the least riskiest approach here and only copy the necessary styles over to the last button container button. This could be cleaned up, but no point when we're switching over to gaia-menu in the future. Simple CSS change in shared, R=me.

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/10ad4fa4b6d0a8b55d74c6248d6778c8b983fae8

Comment 7

[Tony(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The Cancel button is a proper size, consistent with other cancel buttons, and the text is size appropriately.
See attachment: verified_Aries KK_v2.5.png
Reproduce rate: 0/10

Device: Flame KK 2.5 (Pass)
Build ID               20151013150203
Gaia Revision          d400cda6bf0f8b30dcf7d7d71bfa61f29a3f1588
Gaia Date              2015-10-13 06:42:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2387ada864282880d3a498d643abe3d8b887ee59
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151013.182615
Firmware Date          Tue Oct 13 18:26:27 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151013181426
Gaia Revision          d400cda6bf0f8b30dcf7d7d71bfa61f29a3f1588
Gaia Date              2015-10-13 06:42:17
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/2387ada864282880d3a498d643abe3d8b887ee59
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151013.174418
Firmware Date          Tue Oct 13 17:44:27 UTC 2015
Bootloader             s1

Comment 8

[Tony(Leave from Mozilla)]

Attachment: verified_Aries KK_v2.5.png