1213366 - Remove "android:" prefix from colorPrimary*

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Now that we inherit from Theme.AppCompat, as per sebastian's suggestion: https://bugzilla.mozilla.org/show_bug.cgi?id=1213223#c6

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Without that the ActionBar in the settings is black instead of gray:
https://bug1213223.bmoattachments.org/attachment.cgi?id=8671813

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> Without that the ActionBar in the settings is black instead of gray:
> https://bug1213223.bmoattachments.org/attachment.cgi?id=8671813

Okay, you win. :)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1213366 - Remove android: prefix from colorPrimary*. r=sebastian

Bug 1213366 - Remove android: prefix from colorPrimary*. r=sebastian

This changes the color of the settings action bar to grey, as expected.

Note that I was unaware of this no-prefix convention when I wrote the previous
patch and added an "android:actionBarStyle" which may be confusing things
further. We may also benefit from removing the prefix there and fixing the
results.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #2)
> Okay, you win. :)

...win a ticket to review! :D

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #4)
> ...win a ticket to review! :D

wohooo! :)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8672131 [details]
MozReview Request: Bug 1213366 - Remove android: prefix from colorPrimary*. r=sebastian

https://reviewboard.mozilla.org/r/21677/#review19519

Now everything looks great again! :)

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/2a19b0f25a1350d8d8cf252d443a6ce3b661e0bb
Bug 1213366 - Remove android: prefix from colorPrimary*. r=sebastian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a19b0f25a13