1213386 - Cancel button has inconsistent appearance and placement in action menus.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat_cancel-button.txt

Description:
The Cancel button in action menus is inconsistent. When viewing the Power menu, Dialer menus, and Messaging thread menus will display an oval Cancel button with centered text at the bottom of the screen.

In Browser settings and long press menus, the MMS Attachment menu, as well as share menus from gallery, music, videos, and camera, the Cancel button will appear as a rectangular button similar to the other options in the menu, with left aligned text and a blank space below it at the bottom of the screen.

Repro Steps:
1) Update a Aries to 20151009104251
2) Open the Browser app and long press on an image or link.  Note the Cancel button in the Action Menu.
3) Long press the power button to view the Power Menu. Note the Cancel button at the bottom of the screen. 

Actual:
Cancel buttons have inconsistent appearance and placement.

Expected:
Cancel buttons have consistent placement and appearance.

Environmental Variables:
Device: Aries 2.5
Build ID: 20151009104251
Gaia: 1609aecaba381c14eff95d5084e59280f53b7d8b
Gecko: d01dd42e654b8735d86f9e7c723cc869a3b56798
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 5/5
See attached: Screenshot, Logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: Cancel-Button-Screenshot.png

Comment 2

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
Cancel buttons have inconsistent appearance and placement.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151009030234
Gaia: 1609aecaba381c14eff95d5084e59280f53b7d8b
Gecko: d01dd42e654b8735d86f9e7c723cc869a3b56798
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

***************************************

This issue does NOT occur on the latest Flame 2.2 build.
Cancel buttons have consistent placement and appearance.

Environmental Variables:
Device: Flame 2.2
BuildID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a bad end user experience. The cancel button placement should remain consistent throughout so nominating this as a blocker.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

I feel this is a fallout of bug 1196268

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

The Cancel button has been inconsistent in different menus since changes made in bug 1179288. Bug 1196268 is tracking related Gaia fixes. Adding this bug as a dependent of bug 1196268.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

Also NI :kgrandon on this.

Comment 7

[Julien Wajsberg [:julienw]]

Yes, it's in the process of being fixed in the various dependencies of bug 1196268. I'd dupe this to bug 1196268 then.

Comment 8

[Kevin Grandon :kgrandon]

This particular STR will be fixed once bug 1202543 is.

Comment 9

[Kevin Grandon :kgrandon]

Bug 1202543 has landed, so this should be fixed as well.