1213433 - Complete the implementation of chrome.browserAction

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Andy McKay]

The methods on the API are:

https://developer.chrome.com/extensions/browserAction

Currently implemented:

setTitle
getTitle
setIcon
setPopup
getPopup
setBadgeText
getBadgeText
setBadgeBackgroundColor
getBadgeBackgroundColor 

Won't be implemented because they are deprecated:

-

To be implemented:

enable
disable

Comment 1

[Kris Maglione [:kmag]]

Attachment: [webext] Add `enable` and `disable` methods to browserAction API

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8687646 [details] [diff] [review]
[webext] Add `enable` and `disable` methods to browserAction API

Review of attachment 8687646 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks great. There is just one thing that is not clear for me.

::: browser/components/extensions/ext-browserAction.js
@@ +215,5 @@
>        }).api(),
>  
> +      enable: function(tabId) {
> +        let tab = tabId ? TabManager.getTab(tabId) : null;
> +        browserActionOf(extension).setProperty(tab, "enabled", true);

If the tabId is presented but invalid (because the tab is gone already) do we set enable/disable globally here? Is this what chrome does? (the documentation does not mention this case)

Comment 3

[Kris Maglione [:kmag]]

(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #2)
> If the tabId is presented but invalid (because the tab is gone already) do
> we set enable/disable globally here? Is this what chrome does? (the
> documentation does not mention this case)

Hm. Good catch. I think we do. I'll file a follow-up bug.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/4d1341e642b9db3a70d6cf8cfc4c95b0dc723874
Bug 1213433: [webext] Add `enable` and `disable` methods to browserAction API. r=gabor

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d1341e642b9

Comment 6

[Kris Maglione [:kmag]]

Updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities

Comment 7

[Will Bamberg [:wbamberg]]

-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction