[Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

RESOLVED FIXED in Firefox 44

Status

Firefox OS
RIL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

(Blocks: 1 bug)

unspecified
FxOS-S9 (16Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1207936 +++

Split test_ril_worker_cellbroadcast.js into smaller tests in order to prevent  intermittent time out.
(Assignee)

Comment 1

2 years ago
Created attachment 8672217 [details]
MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
(Assignee)

Updated

2 years ago
Blocks: 1130931
(Assignee)

Comment 2

2 years ago
Just simply split test_ril_worker_cellbroadcast into smaller tests.

Summary:
1. Move test_ril_worker_mergeCellBroadcastConfigs() to test_ril_worker_cellbroadcast_config.js
2. Move test_ril_worker_GsmPDUHelper_readGsmCbData() to a new file, test_ril_worker_cellbroadcast_gsm.js
3. Move test_ril_worker_GsmPDUHelper_*Umts*() to a new file, test_ril_worker_cellbroadcast_umts.js
(Assignee)

Comment 3

2 years ago
Comment on attachment 8672217 [details]
MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
Attachment #8672217 - Flags: review?(btseng)
(Assignee)

Comment 4

2 years ago
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb73daecbc4a&exclusion_profile=false
(Those two orange are not related to cellbroadcast).
https://reviewboard.mozilla.org/r/21679/#review19511

Per offline discussion, please help to split the tests as followed:
1. Move all the MMI_SETTABLE related TCs from test_ril_worker_cellbroadcast.js to test_ril_worker_cellbroadcast_config.js.
2. Rename test_ril_worker_cellbroadcast.js to test_ril_worker_cellbroadcast_gsm.js.
3. Move UMTS related TCs into newly created test_ril_worker_cellbroadcast_umts.js.

Thanks!
Comment on attachment 8672217 [details]
MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

https://reviewboard.mozilla.org/r/21681/#review19513
Attachment #8672217 - Flags: review?(btseng)
(Assignee)

Updated

2 years ago
Attachment #8672217 - Flags: review?(btseng)
(Assignee)

Comment 8

2 years ago
Comment on attachment 8672217 [details]
MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
Comment on attachment 8672217 [details]
MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests

https://reviewboard.mozilla.org/r/21681/#review19583

Looks good to me, thanks!
Attachment #8672217 - Flags: review?(btseng) → review+
Assignee: nobody → echen
https://hg.mozilla.org/mozilla-central/rev/137777f64b8c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1207936
You need to log in before you can comment on or make changes to this bug.