Closed
Bug 1213547
Opened 9 years ago
Closed 9 years ago
[Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
FxOS-S9 (16Oct)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1207936 +++ Split test_ril_worker_cellbroadcast.js into smaller tests in order to prevent intermittent time out.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
|
|
Assignee | |
Comment 2•9 years ago
|
||
Just simply split test_ril_worker_cellbroadcast into smaller tests. Summary: 1. Move test_ril_worker_mergeCellBroadcastConfigs() to test_ril_worker_cellbroadcast_config.js 2. Move test_ril_worker_GsmPDUHelper_readGsmCbData() to a new file, test_ril_worker_cellbroadcast_gsm.js 3. Move test_ril_worker_GsmPDUHelper_*Umts*() to a new file, test_ril_worker_cellbroadcast_umts.js
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8672217 [details] MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
Attachment #8672217 -
Flags: review?(btseng)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb73daecbc4a&exclusion_profile=false (Those two orange are not related to cellbroadcast).
|
||
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/21679/#review19511 Per offline discussion, please help to split the tests as followed: 1. Move all the MMI_SETTABLE related TCs from test_ril_worker_cellbroadcast.js to test_ril_worker_cellbroadcast_config.js. 2. Rename test_ril_worker_cellbroadcast.js to test_ril_worker_cellbroadcast_gsm.js. 3. Move UMTS related TCs into newly created test_ril_worker_cellbroadcast_umts.js. Thanks!
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8672217 [details] MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests https://reviewboard.mozilla.org/r/21681/#review19513
Attachment #8672217 -
Flags: review?(btseng)
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/21679/#review19511 Will do, thank you.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8672217 -
Flags: review?(btseng)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Comment on attachment 8672217 [details] MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests
|
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8672217 [details] MozReview Request: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests https://reviewboard.mozilla.org/r/21681/#review19583 Looks good to me, thanks!
Attachment #8672217 -
Flags: review?(btseng) → review+
|
|
||
Updated•9 years ago
|
Assignee: nobody → echen
|
|
Assignee | |
Comment 10•9 years ago
|
||
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bf0798b179e&group_state=expanded
|
||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/137777f64b8c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•