1213568 - Maximize standalone video when pressing F11

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Steffen Wilberg]

Standalone videos should be maximized when pressing F11.

Currently, only the toolbars are hidden, but the size of the video is not enlarged.

It should be maximized instead, just as the Full Screen context menu item of the video does.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This relates to full screen, not video.

Comment 2

[Steffen Wilberg]

Best to use a small video for testing like http://www.quirksmode.org/html5/videos/big_buck_bunny.mp4

Comment 3

[Steffen Wilberg]

CC'ing folks from bug 1137009.

Comment 4

[Steffen Wilberg]

Attachment: MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

Bug 1213568: Maximize standalone video when pressing F11.

Comment 5

[Steffen Wilberg]

Patch depends on bug 1119049, which is on fx-team, but not on m-c yet.

Comment 6

[arni2033]

Err... Could it be Ctrl+F11? Or maybe Ctrl+Enter? Currently those do nothing on page. With F11 you'll get "another Spacebar" which does different action depending on what element is focused. It forces user to watch closely which element is focused - otherwise Spacebar will scroll the page.
Also, see my comment in bug 1119049

Comment 7

[Steffen Wilberg]

Alternate keyboard shortcuts like Ctrl+F11 would do nothing if the location bar or the search bar has focus. I don't think that would be better.

The content area should be focused most of the time. If it doesn't, you can't interact with the video with the keyboard at all.

If you load a video by pasting a link to the location bar, or opening it from disk by pressing Ctrl+O, the content area already has focus. You can press Space to Play/Pause, and with this patch F11 to switch to full screen.

Comment 8

[Steffen Wilberg]

Comment on attachment 8672418 [details]
MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

Bug 1213568: Maximize standalone video when pressing F11.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8672418 [details]
MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

https://reviewboard.mozilla.org/r/21695/#review21395

::: toolkit/content/TopLevelVideoDocument.js:19
(Diff revision 2)
> +  if (ev.key == "F11") {

Is "F11" the fullscreen key on all our platforms?

r=me if it is.  If not, this needs changes, obviously?

Comment 10

[Steffen Wilberg]

https://reviewboard.mozilla.org/r/21695/#review21395

Yes, F11 is used on all platforms.
https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_miscellaneous

Comment 11

[Steffen Wilberg]

https://hg.mozilla.org/integration/fx-team/rev/072c116ae15aefa158b2f2ee13102abc634b460d
Bug 1213568: Maximize standalone video when pressing F11. r=bz

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/072c116ae15a

Comment 13

[:Gijs (he/him)]

(In reply to Steffen Wilberg from comment #10)
> https://reviewboard.mozilla.org/r/21695/#review21395
> 
> Yes, F11 is used on all platforms.
> https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-
> tasks-quickly#w_miscellaneous

That article adapts to your platform. You can configure this on the top left to get its content for another platform (say, OS X). Where the displayed shortcut is:

Toggle Full Screen 	command+Shift+F

This shortcut is localized.

When looking at the code in https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#359 it seems we also support F11 on OSX, apparently, but now this behaviour works on Windows/Linux but not on OSX for the default / most obvious (displayed in menus) shortcut. :-\

Can you file a followup bug?

Comment 14

[Steffen Wilberg]

Oops. Filed bug 1228784.

Comment 15

[Steffen Wilberg]

https://reviewboard.mozilla.org/r/21695/#review31139