Maximize standalone video when pressing F11

RESOLVED FIXED in Firefox 45

Status

()

Core
Layout
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 affected, firefox45 fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Standalone videos should be maximized when pressing F11.

Currently, only the toolbars are hidden, but the size of the video is not enlarged.

It should be maximized instead, just as the Full Screen context menu item of the video does.
This relates to full screen, not video.
Component: Audio/Video: Playback → Layout
(Assignee)

Comment 3

2 years ago
CC'ing folks from bug 1137009.
(Assignee)

Comment 4

2 years ago
Created attachment 8672418 [details]
MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

Bug 1213568: Maximize standalone video when pressing F11.
Attachment #8672418 - Flags: review?(enndeakin)
(Assignee)

Comment 5

2 years ago
Patch depends on bug 1119049, which is on fx-team, but not on m-c yet.

Comment 6

2 years ago
Err... Could it be Ctrl+F11? Or maybe Ctrl+Enter? Currently those do nothing on page. With F11 you'll get "another Spacebar" which does different action depending on what element is focused. It forces user to watch closely which element is focused - otherwise Spacebar will scroll the page.
Also, see my comment in bug 1119049
Flags: needinfo?(steffen.wilberg)
(Assignee)

Comment 7

2 years ago
Alternate keyboard shortcuts like Ctrl+F11 would do nothing if the location bar or the search bar has focus. I don't think that would be better.

The content area should be focused most of the time. If it doesn't, you can't interact with the video with the keyboard at all.

If you load a video by pasting a link to the location bar, or opening it from disk by pressing Ctrl+O, the content area already has focus. You can press Space to Play/Pause, and with this patch F11 to switch to full screen.
Flags: needinfo?(steffen.wilberg)
(Assignee)

Comment 8

2 years ago
Comment on attachment 8672418 [details]
MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

Bug 1213568: Maximize standalone video when pressing F11.
Attachment #8672418 - Flags: review?(enndeakin) → review?(bzbarsky)
Comment on attachment 8672418 [details]
MozReview Request: Bug 1213568: Maximize standalone video when pressing F11.

https://reviewboard.mozilla.org/r/21695/#review21395

::: toolkit/content/TopLevelVideoDocument.js:19
(Diff revision 2)
> +  if (ev.key == "F11") {

Is "F11" the fullscreen key on all our platforms?

r=me if it is.  If not, this needs changes, obviously?
Attachment #8672418 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 11

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/072c116ae15aefa158b2f2ee13102abc634b460d
Bug 1213568: Maximize standalone video when pressing F11. r=bz

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/072c116ae15a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Updated

2 years ago
Depends on: 1226914

Comment 13

2 years ago
(In reply to Steffen Wilberg from comment #10)
> https://reviewboard.mozilla.org/r/21695/#review21395
> 
> Yes, F11 is used on all platforms.
> https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-
> tasks-quickly#w_miscellaneous

That article adapts to your platform. You can configure this on the top left to get its content for another platform (say, OS X). Where the displayed shortcut is:

Toggle Full Screen 	command+Shift+F

This shortcut is localized.

When looking at the code in https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#359 it seems we also support F11 on OSX, apparently, but now this behaviour works on Windows/Linux but not on OSX for the default / most obvious (displayed in menus) shortcut. :-\

Can you file a followup bug?
Flags: needinfo?(steffen.wilberg)
(Assignee)

Updated

2 years ago
Blocks: 1228784
(Assignee)

Comment 14

2 years ago
Oops. Filed bug 1228784.
(Assignee)

Updated

2 years ago
Flags: needinfo?(steffen.wilberg)

Updated

2 years ago
Depends on: 1246128
You need to log in before you can comment on or make changes to this bug.