1246128 - F11 displays the audio container in fullscreen instead of the browser

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Ada [:adalucinet]]

Affected versions: 45 beta 3 (Build ID: 20160204142810), latest Aurora 46.0a2 and Nightly 47.0a1 (from 2016-02-04)
Affected platforms: Windows 7 64-bit, Windows 10 64-bit, Ubuntu 12.04 32-bit, Mac OS X 10.11.1	

Steps to reproduce
1. Launch Firefox.
2. Navigate to https://upload.wikimedia.org/wikipedia/en/4/45/ACDC_-_Back_In_Black-sample.ogg
3. Press F11 (keyboard shortcut).

Expected result: The Browser is displayed in fullscreen.

Actual result: The audio container is displayed in fullscreen.

Regression range:
Last good Nightly: 2015-11-04
First bad Nightly: 2015-11-05
Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=112b9579890ad501b55bdf21cd3eb69b359764c3&tochange=ff8ebe5251ec227be26994089871cb40c1da3011

Maybe regressed by Steffen Wilberg — Bug 1213568: Maximize standalone video when pressing F11. r=bz ?

Comment 1

[Andrew Overholt [:overholt]]

Thanks, Alexandra, bug 1213568 seems likely to me as well.

Steffen, what do you think? Is this intentional?

Comment 2

[Robert Kaiser]

[Tracking Requested - why for this release]:
Regression in 45, bad usability.

Comment 3

[Steffen Wilberg]

I agree. Browser fullscreen is better for standalone audio files because the controls remain visible, whereas they fade out in DOM fullscreen mode.

Comment 4

[Steffen Wilberg]

Attachment: MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

Review commit: https://reviewboard.mozilla.org/r/33931/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33931/

Comment 5

[Steffen Wilberg]

Audio-detection logic is copied from https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/browser/base/content/nsContextMenu.js#707

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

https://reviewboard.mozilla.org/r/33931/#review30703

Comment 7

[Steffen Wilberg]

https://hg.mozilla.org/integration/fx-team/rev/baf5dfffbc347cef3d7152f5b5d7ad7408a3f69d
Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r=bz

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for the last ESLint failure in https://treeherder.mozilla.org/logviewer.html#?job_id=7155701&repo=fx-team

 TEST-UNEXPECTED-ERROR | toolkit/content/TopLevelVideoDocument.js:11:10 | Parsing error: Illegal return statement 

https://hg.mozilla.org/integration/fx-team/rev/49945e5fe79e

Unsure exactly what would fix this offhand.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Oh, this is at toplevel.  So "return" makes no sense there...  You really do need to reindent things and nest them.

Comment 10

[Steffen Wilberg]

Oh crap, I failed to test properly.

Comment 11

[Steffen Wilberg]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33931/diff/1-2/

Comment 12

[Steffen Wilberg]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

>https://reviewboard.mozilla.org/r/33931/diff/#index_header

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

https://reviewboard.mozilla.org/r/33931/#review30935

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

https://reviewboard.mozilla.org/r/33931/#review31047

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7635436c1423

Comment 16

[arni2033]

(In reply to Steffen Wilberg from comment #3)
> I agree. Browser fullscreen is better for standalone audio files because the
> controls remain visible, whereas they fade out in DOM fullscreen mode.
Such a drastic change of view, see bug 1226914 comment 3
So bugs are only important if they are reported by certain people, huh.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7635436c1423

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Steffen, could you fill the uplift request to aurora and beta? Thanks

Regression, tracking

Comment 19

[Steffen Wilberg]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

Approval Request Comment
[Feature/regressing bug #]: In bug 1213568 (on firefox45), I made pressing F11 when viewing standalone media documents go to DOM fullscreen. This is desirable for videos to view them maximized. For audio files however, DOM fullscreen simply displays a black screen. This patch reverts that, so audio files still show the controls in fullscreen mode.
[User impact if declined]: Black screen after pressing F11 in standalone audio documents
[Describe test coverage new/current, TreeHerder]: manual tessting
[Risks and why]: minimal; this is a one-liner in a javascript file only loaded for standalone media documents
[String/UUID change made/needed]: none

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8716767 [details]
MozReview Request: Bug 1246128: F11 displays the audio container in fullscreen instead of the browser. r?bz

Fix for recent regression, please uplift to aurora and beta.

Comment 21

[Steffen Wilberg]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3fe720e0622
https://hg.mozilla.org/releases/mozilla-beta/rev/ab104d03fabf

Comment 22

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug with Firefox Nightly 47.0a1 (2016-02-04);(Build ID: 20160204030229) on Linux, 64 Bit with the instructions from comment 0.

This Bug is now verified as fixed on Latest Firefox Beta 45.0b7 (Build ID: 20160218171844)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 ; 

Latest Firefox Developer Edition 46.0a2 (2016-02-18) ; (Build ID: 20160218004005)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0 and

Latest Firefox Nightly 47.0a1 (2016-02-18) ; (Build ID: 20160218030349)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0

Comment 23

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 47.0a1 (Build ID:20160205030204) on 
windows 8.1 64-bit with the instructions from comment 0.

Verified as fixed with latest Firefox Nightly 47.0a1 (Build ID: 20160218030349)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

Verified as fixed with latest Firefox Aurora 46.0a2 (Build ID:20160218004005)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

Fix is not working with Firefox beta 45.0b6 (Build ID:20160215141016)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 24

[Steffen Wilberg]

(In reply to Mohammad Maruf Islam from comment #23)
> Fix is not working with Firefox beta 45.0b6 (Build ID:20160215141016)
> Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

You say that is is NOT working, but you mark it as verified fixed.
It is woking or not?

Comment 25

[Mohammad Maruf Islam]

(In reply to Steffen Wilberg from comment #24)
> (In reply to Mohammad Maruf Islam from comment #23)
> > Fix is not working with Firefox beta 45.0b6 (Build ID:20160215141016)
> > Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
> 
> You say that is is NOT working, but you mark it as verified fixed.
> It is woking or not?

The Fix is not working with Firefox beta 45.0b6 (Build ID:20160215141016)on my Windows 8.1,64-bit. But the fix is working with latest nightly and aurora.(Mentioned Build IDs of Nightly and Aurora on comment 23) I have tried with new profile several times . But still I don't know why the Fix is just not working with Firefox beta 45.0b6 .As I understand from the tracking flags , the fix should also work with the latest beta (45.0b6).

As this fix is working with Firefox Aurora 46.0a2 and Nightly 47.0a1,So, I marked verified on the status-firefox46 and status-firefox47.But, I didn't change the Bug status .

Comment 26

[Steffen Wilberg]

I see, beta is 45, where this is correctly marked as fixed but not yet verified.
FIREFOX_45_0b6_RELEASE was tagged on February 15, before this fix was landed (on February 17).
45b7 will have the fix, but is not available via automatic update yet.

Comment 27

[raknarrok]

Hi Team,

I already tested the issue on my machine 

OS: Windows 7 (64 bits). 
FF: 47.0a2 (2016-04-15)

The issue is not longer displayed, im not sure if someone can confirm that.

Steps to reproduce
1. Launch Firefox.
2. Navigate to https://upload.wikimedia.org/wikipedia/en/4/45/ACDC_-_Back_In_Black-sample.ogg
3. Press F11 (keyboard shortcut).

Expected result: The Browser is displayed in fullscreen.

let me know if you need something else. Thanks in advance.

Regards,
Luis Fernandez

Comment 28

[Mohammad Maruf Islam]

I had already reproduced the bug on windows 8.1,64-bit and also verified the fix with nightly and aurora (See comment 23).

The fix is verified with latest Firefox release 45.0.2 (Build ID:20160407164938).
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

As this bug is also verified on Linux (Comment 22), I am marking this as verified!